Fix list editor panics during insertion

[Frizi]

Fixes #6522

• Fixed occasional panics when inserting or moving elements around.
• Improved mouse events handling in list editor to behave correctly during box selection.
• Removed vectorEditor feature flag, enabling the list editor permanently.
• Replaced node background shape with Rectangle and removed unnecessary separation between hover area and background. Switched node hover state to use new mouse events system.
• Adjusted size of hover area of the list editor such that it is harder do accidentally insert a new element and easier to drag the nodes around.
• Fixed mouse down event propagation inside list editor when clicking without dragging. This allows dropdowns nested within list items to work correctly.
  
  
  

Important Notes

The mouse handling changes involve an unfortunate huge hack, where we enable mouse events on the mouse shape during box selection. That way we know for sure that no other shape will be able to receive mouse enter event. Then the list editor widget is modified to only actually respond to events when its background is hovered. We will definitely want a more proper way to handle mouse event contention, but it's definitely out of scope for current bugfixing.

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

• The documentation has been updated, if necessary.
• Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
• All code follows the
  Scala,
  Java,
  and
  Rust
  style guides. In case you are using a language not listed above, follow the Rust style guide.
• All code has been tested:
  • Unit tests have been written where possible.
  • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

[wdanilo]

why this change? The gap was there to display + button when the mouse is cldse to the edge of lit editor. Without this change it will not be visible, right?

[Frizi]

It is visible, the area is just intentionally made a little smaller. The gap was extending the active bounding box in both X and Y axis. Y axis extension wasn't desirable, as it made the insertions way too easy to do accidentally, especially when attempting to drag the node.

[wdanilo]

Wait, but dragging the node by clicking above / below list editor should be hardly supported / unsupported. I mean, there is just a few pixels for that and assuming someone would be able to find these pixels is bad. I prefer the drag areas to be bigger to easier initiate dragging / insertion of elements. Of course, currently there is problem with node dragging because we don't have the icons on the left, but it is not solvable by making this are smaller IMO.

[Frizi]

I will adjust that when working on new node design, as we will have slightly more area to work with. For now, it behaves much better that way. It is still not hard to drag the elements, you simply drag the text anywhere. Also, using gap to extend drag area vertically was a little surprising to me. I would prefer that to be a separate configuration input, if we need one.

[jdunkerley]

Quick feedback from trying this branch. The Vector Dropdowns now work :).

But has a detrimental affect on being able to connect links.

2023-05-05_10-25-44.mp4

[jdunkerley]

Stuff from my trying to use this build today:

• As above dragging to establish a connection is hard.
• Ctrl clicking into edit a node, then moving the cursor by clicking doesn't seem to work.
• If a Vector is pointed at a non-vector (e.g. single value or a function) then you just get a dot.

- Seemed to get extra dots on things that aren't vectors.

- The + to add the first item doesn't seem to work. - Comma's seems to be sometimes visible and sometimes not.

[Frizi]

I have fixed the issues with edge dragging. My previous event resume implementation have broken the mouse down events in new event system. Now it works again and nodes can be connected as expected, including inside list editor. Ctrl clicking/edit mode is also fixed with that.

[vitvakatu]

QA Report 🔴

1. Adding new elements to the empty vector is not working – the grey circle is unclickable.

Also, split does not have the first argument inside the array, see the video:

2023-05-09.17-15-56.mp4

2. When dragging the edge over the vector editor, the cursor behaves weirdly, changing the shape to plus when between placeholders. Clicking on a free space with a plus cursor uses the nearest placeholder, but removing the connection also removes the element from the vector. It is asymmetrical behavior, I think dropping a new element with a plus shape should add the element, not reuse the nearest one.
   Moreover, it requires exceptionally gentle positioning of the mouse pointer – a slight movement of a few pixels to the side completely changes the target port, which can confuse users. ("Damn, I hate this pixel-hunting just to connect the edge to the element").

2023-05-09.17-50-18.mp4

[sylwiabr]

@Frizi what is the status? I would love to test it :)

[vitvakatu]

QA Report 🔴

In general, looks much nicer. I like how dropping the edge to the vector looks and works now.

There are still issues that I spotted, but they might be fixed separately, I suppose:

1. On the node table.rename_columns Map.from_vector, the Map.from_vector part is not visible.

2. Adding elements to the vector after Map.from_vector adds Boolean.True. That is probably incorrect (it's probably an engine issue, though).
3. Connecting the edge to this vector is hard. It's hard to find a free place. It seems like the free place is right on top of the square bracket. That seems weird. In the video, you can see that I try to target that point for a very long time. Again, pixel-hunting is depressing.

2023-05-15.20-42-49.mp4

4. Sometimes (almost every time for me), dropping the edge there adds two elements.

2023-05-15.20-43-21.mp4

5. After recording the previous video, I removed the first element of the vector, and the cursor got stuck in the red cross state. Hovering the node again fixed it, so it is not that important.

6. There is a place where the cursor turns green on this node, and pressing LMB produces bizarre code modifications. I don't see the same behavior for other functions, like String.split.

2023-05-15.20-44-33.mp4

[Frizi]

PR is now ready for another QA round.

[vitvakatu]

QA passed 💚