Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When trying to select a node with a vector new elements are accidentally added #6529

Closed
1 of 2 tasks
sylwiabr opened this issue May 3, 2023 · 4 comments
Closed
1 of 2 tasks
Assignees
Labels
--bug Type: bug d-easy Difficulty: little prior knowledge required p-high Should be completed in the next sprint

Comments

@sylwiabr
Copy link
Member

sylwiabr commented May 3, 2023

Discord username

No response

What type of issue is this?

Permanent – Occurring repeatably

Is this issue blocking you from using Enso?

  • Yes, I can't use Enso because of this issue.

Is this a regression?

  • Yes, previous version of Enso did not have this issue.

What issue are you facing?

selecting_vector.mov

When trying to select a node with a vector, node is getting selected but also new element is added.

Expected behaviour

Selecting nodes should be easy.

How we can reproduce it?

No response

Screenshots or screencasts

No response

Enso Version

nightly 03.05

Browser or standalone distribution

Standalone distribution

Browser Version or standalone distribution

standalone

Operating System

MacOS

Operating System Version

No response

Hardware you are using

No response

@wdanilo
Copy link
Member

wdanilo commented May 3, 2023

This is caused by mouse not always showing the + icon. The icon should be shown if you place the mouse between items.

@wdanilo
Copy link
Member

wdanilo commented May 3, 2023

Also, the new design has an icon always on the left side of the node:
image

Until we do it, dragging nodes with only widgets would be hard, so we could implement the new node deign ASAP.

@4e6 4e6 added -gui and removed triage labels May 3, 2023
@farmaazon
Copy link
Contributor

farmaazon commented May 10, 2023

Currently, adding a new element is fired on every up event, but I think we should fire it only when the down event was also in the list editor (or even in the right gap).

To be done after #6549 as the architecture of event handling may be revised there.

@farmaazon farmaazon added d-easy Difficulty: little prior knowledge required p-high Should be completed in the next sprint labels May 10, 2023
@farmaazon farmaazon added this to the Design Partners milestone May 10, 2023
@farmaazon farmaazon moved this from ❓New to 📤 Backlog in Issues Board May 10, 2023
@farmaazon
Copy link
Contributor

After fixes in #6540 I cannot reproduce adding new element (it's added only when cursor is plus, but this is expected). Also selecting with box and ending selection between elements didn't add elements to list editor.

The node is often not selected, but that's another issue: #6677

@sylwiabr please check it also and if you reproduce, please reopen this issue.

@github-project-automation github-project-automation bot moved this from 📤 Backlog to 🟢 Accepted in Issues Board May 19, 2023
@farmaazon farmaazon moved this from 🟢 Accepted to 🗄️ Archived in Issues Board May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
--bug Type: bug d-easy Difficulty: little prior knowledge required p-high Should be completed in the next sprint
Projects
Archived in project
Development

No branches or pull requests

4 participants