Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Widgets fail to parse in the IDE if their label or code contains a double quote " #6657

Closed
radeusgd opened this issue May 12, 2023 · 1 comment · Fixed by #6540
Closed

Widgets fail to parse in the IDE if their label or code contains a double quote " #6657

radeusgd opened this issue May 12, 2023 · 1 comment · Fixed by #6540
Assignees
Labels
--bug Type: bug

Comments

@radeusgd
Copy link
Member

Repro:

  • modify some custom widget to contain a "
  • open the IDE with the widget displayed

I modified Text_Sub_Range.default_widget (currently on my PR #6641, should be merged soon, it can also be tested on any other widget):

diff --git a/distribution/lib/Standard/Base/0.0.0-dev/src/Data/Text/Text_Sub_Range.enso b/distribution/lib/Standard/Base/0.0.0-dev/src/Data/Text/Text_Sub_Range.enso
--- a/distribution/lib/Standard/Base/0.0.0-dev/src/Data/Text/Text_Sub_Range.enso	(revision 607a45525f30fdece328a8a58a308f345bc02b7c)
+++ b/distribution/lib/Standard/Base/0.0.0-dev/src/Data/Text/Text_Sub_Range.enso	(date 1683889513913)
@@ -58,7 +58,7 @@
     ## PRIVATE
     default_options : Vector Option
     default_options =
-        o1 = Option "Before" "(Text_Sub_Range.Before ' ')"
+        o1 = Option 'has a " quote' "(Text_Sub_Range.Before ' ')"
         o2 = Option "Before_Last" "(Text_Sub_Range.Before_Last ' ')"
         o3 = Option "After" "(Text_Sub_Range.After ' ')"
         o4 = Option "After_Last" "(Text_Sub_Range.After_Last ' ')"

Then I open a project that has a Text.take node in it:
image

I can see the issue in the logs:
image

And when I open the widget, I can see it fell back to default instead of my custom one, due to this issue:
image

@Frizi Frizi removed the triage label May 12, 2023
@Frizi Frizi linked a pull request May 12, 2023 that will close this issue
5 tasks
@Frizi
Copy link
Contributor

Frizi commented May 12, 2023

This will be addressed in #6540

@mergify mergify bot closed this as completed in #6540 May 17, 2023
@github-project-automation github-project-automation bot moved this from ❓New to 🟢 Accepted in Issues Board May 17, 2023
@farmaazon farmaazon moved this from 🟢 Accepted to 🗄️ Archived in Issues Board May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
--bug Type: bug
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants