Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy-paste a single node #6261

Closed
sylwiabr opened this issue Apr 13, 2023 · 8 comments · Fixed by #7618
Closed

Copy-paste a single node #6261

sylwiabr opened this issue Apr 13, 2023 · 8 comments · Fixed by #7618
Assignees
Labels
p-high Should be completed in the next sprint x-new-feature Type: new feature request
Milestone

Comments

@sylwiabr
Copy link
Member

sylwiabr commented Apr 13, 2023

Discord username

No response

How important is this feature to you?

3 – Lack of it makes using Enso slightly harder

Describe the idea you'd like to see implemented.

Right now there is no way for a user to copy and paste a node without going to edition mode. In the first implementation it should just allow for a single node to copy and paste.

Is your feature request related to a problem?

No response

Screenshots, screencasts, mockups.

No response

Would you be willing to help us implement this feature?

No

@sylwiabr sylwiabr removed the triage label Apr 13, 2023
@farmaazon farmaazon moved this from ❓New to 📤 Backlog in Issues Board Apr 17, 2023
@sylwiabr sylwiabr added this to the Beta Release milestone Apr 17, 2023
@sylwiabr sylwiabr added the p-high Should be completed in the next sprint label Jun 1, 2023
@farmaazon farmaazon assigned kazcw and vitvakatu and unassigned farmaazon and kazcw Aug 7, 2023
@enso-bot
Copy link

enso-bot bot commented Aug 14, 2023

Ilya Bogdanov reports a new STANDUP for the provided date (2023-08-11):

Progress: Mostly doing non-coding stuff: triage, reviews, QAs, bookclub. Started investigating how to transfer the node's metadata through the clipboard It should be finished by 2023-08-18.

Next Day: Next day I will be working on the same task. actually working on task

@vitvakatu vitvakatu moved this from 📤 Backlog to 🔧 Implementation in Issues Board Aug 14, 2023
@enso-bot
Copy link

enso-bot bot commented Aug 14, 2023

Ilya Bogdanov reports a new STANDUP for today (2023-08-14):

Progress: Weekly demo, QA of the top bar fixes. Started working on the task and implemented a draft version of copy-pasting. It should be finished by 2023-08-18.

Next Day: Next day I will be working on the same task. continue working on implementation

@enso-bot
Copy link

enso-bot bot commented Aug 16, 2023

Ilya Bogdanov reports a new STANDUP for yesterday (2023-08-15):

Progress: Implementing custom format for clipboard content, investigation of chromium support of custom formats. It should be finished by 2023-08-18.

@enso-bot
Copy link

enso-bot bot commented Aug 17, 2023

Ilya Bogdanov reports a new STANDUP for yesterday (2023-08-16):

Progress: Implemented metadata copying and pasting at the cursor position. Refactored the code and improved error handling. It should be finished by 2023-08-18.

Next Day: Next day I will be working on the same task. Polish the code and prepare a PR.

@enso-bot
Copy link

enso-bot bot commented Aug 17, 2023

Ilya Bogdanov reports a new STANDUP for today (2023-08-17):

Progress: Improved API for better logical separation of modules, testing and polishing the solution, and adding documentation. Repeated QAs for PRs 7507 and 7516. Still need to fix a few things, so I will open a PR the next day. It should be finished by 2023-08-18.

@vitvakatu vitvakatu mentioned this issue Aug 21, 2023
5 tasks
@vitvakatu vitvakatu moved this from 🔧 Implementation to 👁️ Code review in Issues Board Aug 21, 2023
@enso-bot
Copy link

enso-bot bot commented Aug 21, 2023

Ilya Bogdanov reports a new STANDUP for the provided date (2023-08-18):

Progress: Polishing the code and refactoring, adding docs. It should be finished by 2023-08-18.

@enso-bot
Copy link

enso-bot bot commented Aug 21, 2023

Ilya Bogdanov reports a new 🔴 DELAY for today (2023-08-21):

Summary: There is 4 days delay in implementation of the Copy-paste a single node (#6261) task.
It will cause 0 days delay for the delivery of this weekly plan.

2 days are weekends

Delay Cause: Preparing a PR took longer than anticipated because I hate writing documentation.

@enso-bot
Copy link

enso-bot bot commented Aug 21, 2023

Ilya Bogdanov reports a new STANDUP for today (2023-08-21):

Progress: Opened a PR. Planning call, weekly demo, implemented a quick fix for displayed project name when renaming the project. Tried to implement support for plain text pasting in external programs but failed. It should be finished by 2023-08-22.

Next Day: Next day I will be working on the #7468 task. Starting to work on a new issue.

@vitvakatu vitvakatu moved this from 👁️ Code review to 🌟 Q/A review in Issues Board Aug 22, 2023
@farmaazon farmaazon moved this from 🌟 Q/A review to 🟢 Accepted in Issues Board Aug 30, 2023
@mergify mergify bot closed this as completed in #7618 Aug 30, 2023
mergify bot pushed a commit that referenced this issue Aug 30, 2023
Closes #6261

- Adds support for copy-pasting nodes with `cmd + C` and `cmd + V` shortcuts.
- Only a single, currently selected node will be copied. Adding support for multiple node copies seems easy, though (but was out of the scope of the task).
- We use a custom data format for clipboard content. Node's metadata is also copied, so opened visualizations are preserved. However, the visualization's size is not preserved, as we do not store this info in metadata.
- For custom format to work, we use a pretty new feature called [Clipboard pickling](https://github.com/w3c/editing/blob/gh-pages/docs/clipboard-pickling/explainer.md), but it is available in Electron and in most browsers already.
- Pasting plain text from other applications (or from Enso, if the code is copied in edit mode) is supported and is currently enabled. There are some security concerns related to this, though. I will create a separate issue/discussion for that.
- Undo/redo works as you expect.
- New node is pasted at the cursor position.


https://github.com/enso-org/enso/assets/6566674/7a04d941-19f7-4a39-9bce-0e554af50ba3
@farmaazon farmaazon moved this from 🟢 Accepted to 🗄️ Archived in Issues Board Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p-high Should be completed in the next sprint x-new-feature Type: new feature request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants