Automatic Dropdown support for single Atom types does not work

[jdunkerley]

Any dropdown being chosen which is an Atom only type (e.g. Report_Unmatched) results in an incorrect import being added.

The import causes ambiguous import errors (as then both the module and type are imported).

Can be worked around by custom dropdowns but this should be fixed.

[hubertp]

@Frizi is that you area? Maybe you can let us know if something is missing from LS support?

[Frizi]

I'm not sure what's the expected and observed result here. For me, selecting Report Unmatched from a dropdown doesn't result in any errors. I've checked that union has no override, and the default static tag value is used.

The generated code looks like this:

from Standard.Table.Data import Report_Unmatched
...
operator6 = operator8.union [operator8] keep_unmatched_columns=Report_Unmatched.Report_Unmatched

Is this incorrect?

[farmaazon]

@jdunkerley ^ could you post here an exact scenario where "ambiguous import" happens?

[jdunkerley]

The additional import is creating a clash with Report_Unmatched included in from Standard.Table import all.

• The type Standard.Table.Data.Report_Unmatched.Report_Unmatched is exported by Standard.Table.
• The added import brings in the module Standard.Table.Data.Report_Unmatched causing am abiguous import.

We should just put the type in as the chosen option (i.e. just Report_Unmatched here not Report_Unmatched.Report_Unmatched) and detect that this is already imported.

The issue with Nothing.Nothing bug is exactly the same as this case.

[enso-bot]

Ilya Bogdanov reports a new STANDUP for today (2023-08-22):

Progress: Investigated the code and decided what needs to be done. Implemented a draft solution for choosing the correct expression. A proper solution is complicated because of suggestion database restrictions. Also finished the implementation of pasting nodes as plain text with the help of Pawel. It should be finished by 2023-08-24.

Next Day: Next day I will be working on the same task. continue working on the draft solution, investigating alternative implementations for the suggestion database.

[enso-bot]

Ilya Bogdanov reports a new STANDUP for yesterday (2023-08-23):

Progress: Further investigation, added the code for exporting suggestion database in JSON for analysis. It should be finished by 2023-08-24.

[enso-bot]

Ilya Bogdanov reports a new STANDUP for today (2023-08-24):

Progress: Investigating found the specific reason for the issue and a way to fix it. Considering different solutions. Also faced a peculiar bug when the lookup by the qualified name of the entry fails, even though the entry is present in the database. Found some issues in the hierarchy index implementation as well. It should be finished by 2023-08-24.

[enso-bot]

Ilya Bogdanov reports a new 🔴 DELAY for the provided date (2023-08-25):

Summary: There is 5 days delay in implementation of the Automatic Dropdown support for single Atom types does not work (#7468) task.
It will cause 1 day delay for the delivery of this weekly plan.

2 days are weekends

Delay Cause: The investigation took more time than initially estimated, mostly because I wasn't feeling confident with all the intricacies of the suggestion database. Also, we're short on people this week, so reviews and QAs are delayed.

[enso-bot]

Ilya Bogdanov reports a new STANDUP for the provided date (2023-08-25):

Progress: With the help of Pawel, I investigated further and found the real issue. My clever tricks with the hierarchy index are not necessary. Instead, I need to refactor the code. Working on the solution. Also addressed review comments in copy-pasting nodes. It should be finished by 2023-08-29.