-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copy-pasting nodes #7618
Copy-pasting nodes #7618
Conversation
/// AST of the node's expression. Typically no external user wants to access it directly. Use | ||
/// [`Self::expression`] instead. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docs accurate?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, it's still not typical to use it, but in this case we need it.
On the demo, we discussed that it would be nice to copy nodes to external programs as plain text, but it turns out to be quite hard to implement, as multiple clipboard items are not supported on most platforms: https://bugs.chromium.org/p/chromium/issues/detail?id=1171260. So we either need to step back from this feature, which is bad, or use plain text format, which is also bad, as we won't be able to copy metadata and do other cool things in the future. I need to research how it is done in other programs, as I can clearly copy syntax highlighting from some editors and at the same time operate with copied code as with plain text in other programs. @wdanilo, what do you think? |
Co-authored-by: Kaz Wesley <[email protected]>
Ok, let's merge this one, and let's think about external apps support in a separate issue. |
Thanks to @Frizi for helping with the investigation. Turns out I was confused by the documentation. Added support for pasting to external programs as plain text. |
All issues were addressed. |
QA Report: 🟢Issues fixed, no more found. |
Pull Request Description
Closes #6261
cmd + C
andcmd + V
shortcuts.Kapture.2023-08-21.at.13.37.40.mp4
Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
./run ide build
.