-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Vector_Editor
widget to graph editor
#5631
Comments
Depends on #5134 |
@Frizi you made my day with this design :D |
This is the one from https://www.figma.com/file/Gouv03sV4Oi2btc8qula1h/API-Design?node-id=0%3A1 which we used as a reference when discussing it for the first time with @jdunkerley. I guess this one is more adequate now: Though a simpler example of e.g. a list of strings or numbers would be even more helpful. |
Adam Obuchowicz reports a new STANDUP for today (2023-03-14): Progress: A day of many calls. Discussed the Execution Modes and the Widgets. Started making task list for the Vector_Editer Widget epic. It should be finished by 2023-03-15. Next Day: Next day I will be working on the same task. finish tasks, split them between me and Wojciech and start doing my first task. |
Tasks
Vector_Editor
widget under the current node #5946Vector_Editor
component allowing element adding. #6037Vector_Editor
widget: Adding elements #5947Vector_Editor
component: Removing elements #6038Vector_Editor
widget: Removing elements #5948Vector_Editor
component: Moving elements #6039Vector_Editor
widget: Moving elements #5949Vector_Editor
widget: Drop-down as a sub-widget #5950Support node widget that operates on lists of values. It needs to allow:
The engine provided widget type will specify the default value to insert on add action (
idem_default
), and a widget to use for existing items (item_editor
).Reference design:
![image](https://user-images.githubusercontent.com/919491/218160117-6d5b2695-0aab-4997-88d0-d8312e1018ac.png)
The vector editor needs to be rendered as part of the node. This will likely require refactoring node input ports rendering to allow inserting interactive UI elements in between fragments of code text.
Acceptance criteria:
A node with
Table.select_columns
method should receive a vector widget oncolumns
parameter that allows editing a list of selected columns. All of adding, removing, reordering and modifying already present names should be supported.The text was updated successfully, but these errors were encountered: