Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Vector_Editor widget to graph editor #5631

Closed
9 tasks done
Frizi opened this issue Feb 10, 2023 · 4 comments
Closed
9 tasks done

Add support for Vector_Editor widget to graph editor #5631

Frizi opened this issue Feb 10, 2023 · 4 comments
Assignees
Labels
d-hard Difficulty: significant prior knowledge required x-new-feature Type: new feature request x-user-story Type: new user story
Milestone

Comments

@Frizi
Copy link
Contributor

Frizi commented Feb 10, 2023

Tasks

Preview Give feedback
  1. -gui d-intermediate g-widgets p-high x-new-feature
    farmaazon
  2. -gui d-easy g-widgets p-high x-new-feature
    wdanilo
  3. -gui d-intermediate g-widgets p-high x-new-feature
    farmaazon
  4. -gui d-easy g-widgets x-new-feature
    wdanilo
  5. -gui d-easy g-widgets p-high x-new-feature
    farmaazon
  6. -gui d-intermediate g-widgets p-high x-new-feature
    wdanilo
  7. -gui d-intermediate g-widgets p-high x-new-feature
    farmaazon
  8. -gui d-hard g-widgets p-high x-new-feature
    farmaazon
  9. -gui d-hard g-widgets p-high x-new-feature
    Frizi farmaazon

Support node widget that operates on lists of values. It needs to allow:

  • adding new entry to the list (a + button)
  • removing existing entries from the list (e.g. by dragging them out of the node)
  • reordering existing entries in the list (e.g. by dragging them around)
  • editing existing entries using specified item widget

The engine provided widget type will specify the default value to insert on add action (idem_default), and a widget to use for existing items (item_editor).

Vector_Editor
  item_editor: Widget
  item_default: Text
  label: (Nothing | Text) = Nothing
  display: Display = Display.When_Modified

Reference design:
image

The vector editor needs to be rendered as part of the node. This will likely require refactoring node input ports rendering to allow inserting interactive UI elements in between fragments of code text.

Acceptance criteria:

A node with Table.select_columns method should receive a vector widget on columns parameter that allows editing a list of selected columns. All of adding, removing, reordering and modifying already present names should be supported.

@Frizi Frizi added d-hard Difficulty: significant prior knowledge required x-new-feature Type: new feature request g-graph-editor labels Feb 10, 2023
@Frizi Frizi self-assigned this Feb 10, 2023
@jdunkerley jdunkerley added this to the Beta Release milestone Feb 13, 2023
@Frizi
Copy link
Contributor Author

Frizi commented Feb 21, 2023

Depends on #5134

@farmaazon farmaazon moved this from ❓New to 📤 Backlog in Issues Board Feb 21, 2023
@wdanilo
Copy link
Member

wdanilo commented Feb 21, 2023

@Frizi you made my day with this design :D

@Frizi
Copy link
Contributor Author

Frizi commented Feb 21, 2023

This is the one from https://www.figma.com/file/Gouv03sV4Oi2btc8qula1h/API-Design?node-id=0%3A1 which we used as a reference when discussing it for the first time with @jdunkerley. I guess this one is more adequate now:

union node

Though a simpler example of e.g. a list of strings or numbers would be even more helpful.

@farmaazon farmaazon added the x-user-story Type: new user story label Mar 14, 2023
@farmaazon farmaazon assigned farmaazon and unassigned Frizi Mar 14, 2023
@farmaazon farmaazon moved this from Todo to Design in progress in Epics Board Mar 14, 2023
@farmaazon farmaazon moved this from 📤 Backlog to ⚙️ Design in Issues Board Mar 14, 2023
@enso-bot
Copy link

enso-bot bot commented Mar 14, 2023

Adam Obuchowicz reports a new STANDUP for today (2023-03-14):

Progress: A day of many calls. Discussed the Execution Modes and the Widgets. Started making task list for the Vector_Editer Widget epic. It should be finished by 2023-03-15.

Next Day: Next day I will be working on the same task. finish tasks, split them between me and Wojciech and start doing my first task.

@farmaazon farmaazon moved this from Design in progress to Implementation in progress in Epics Board Mar 28, 2023
@github-project-automation github-project-automation bot moved this from Implementation in progress to Done in Epics Board May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
d-hard Difficulty: significant prior knowledge required x-new-feature Type: new feature request x-user-story Type: new user story
Projects
Archived in project
Development

No branches or pull requests

4 participants