Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vector_Editor widget under the current node #5946

Closed
Tracked by #5631
farmaazon opened this issue Mar 15, 2023 · 9 comments · Fixed by #6142
Closed
Tracked by #5631

Vector_Editor widget under the current node #5946

farmaazon opened this issue Mar 15, 2023 · 9 comments · Fixed by #6142
Assignees
Labels
d-intermediate Difficulty: some prior knowledge required p-high Should be completed in the next sprint x-new-feature Type: new feature request

Comments

@farmaazon
Copy link
Contributor

farmaazon commented Mar 15, 2023

This task is a preparation for developing vector_editor, such that we will not interfere with the new way of displaying widgets in the node (#5134)

If the node contains an array, it should display a triangle under it, which will show a Vector_Editor widget under it. The scope of this task does not include any form of editing the vector nor its content.

The vector builder should show the list of elements. For future implementation, it would be good to have them as a separate display::Objects.

Add a debug scene with the sole widget for faster future development. Also, remember auto-layouts!

@farmaazon farmaazon changed the title Integrate Vector_Editor widget with new widgets hierarchy Vector_Editor widget under the current node Mar 15, 2023
@farmaazon farmaazon added -gui d-intermediate Difficulty: some prior knowledge required p-high Should be completed in the next sprint x-new-feature Type: new feature request labels Mar 15, 2023
@farmaazon farmaazon added this to the Design Partners milestone Mar 15, 2023
@farmaazon farmaazon moved this from ❓New to 🔧 Implementation in Issues Board Mar 15, 2023
@enso-bot
Copy link

enso-bot bot commented Mar 20, 2023

Adam Obuchowicz reports a new STANDUP for the last Friday (2023-03-17):

Progress: Much time spent on reviewing and testing "Improving Performance Monitor #5895". Also finished implementation of stub Vector_Editor widget, but didn't realized how to enforce vector widget in the area::Input. It should be finished by 2023-03-20.

Next Day: Next day I will be working on the same task. Try to finish the issue to have something to demo.

@enso-bot
Copy link

enso-bot bot commented Mar 21, 2023

Adam Obuchowicz reports a new 🔴 DELAY for yesterday (2023-03-20):

Summary: There is 2 days delay in implementation of the Vector_Editor widget under the current node (#5946) task.
It will cause 2 days delay for the delivery of this weekly plan.

Delay Cause: Side discussions and somehow low performance last week.

@enso-bot
Copy link

enso-bot bot commented Mar 21, 2023

Adam Obuchowicz reports a new STANDUP for yesterday (2023-03-20):

Progress: Tried the simple integration, but somehow it breaks the thing completely (including drop down widgets), haven't time to debug that properly. It should be finished by 2023-03-22.

Next Day: Next day I will be working on the same task. Debug and fix all issues. If lucky, make a PR.

@enso-bot
Copy link

enso-bot bot commented Mar 22, 2023

Adam Obuchowicz reports a new 🔴 DELAY for yesterday (2023-03-21):

Summary: There is 2 days delay in implementation of the Vector_Editor widget under the current node (#5946) task.
It will cause 2 days delay for the delivery of this weekly plan.

Delay Cause: Doing reviews and QAs of some tasks, but most prominently: the debugging visuals part of integration was much harder than I remembered.

@enso-bot
Copy link

enso-bot bot commented Mar 22, 2023

Adam Obuchowicz reports a new STANDUP for yesterday (2023-03-21):

Progress: Debugged many issues, but still some remains. It should be finished by 2023-03-24.

Next Day: Next day I will be working on the same task. Debug and fix all issues, and make a PR

@enso-bot
Copy link

enso-bot bot commented Mar 23, 2023

Adam Obuchowicz reports a new STANDUP for yesterday (2023-03-22):

Progress: The widget shows proper elements, but still have some problems with positioning It should be finished by 2023-03-24.

Next Day: Next day I will be working on the same task. Debug and fix all issues, and make a PR

@enso-bot
Copy link

enso-bot bot commented Mar 24, 2023

Adam Obuchowicz reports a new 🔴 DELAY for yesterday (2023-03-23):

Summary: There is 4 days delay in implementation of the Vector_Editor widget under the current node (#5946) task.
It will cause 4 days delay for the delivery of this weekly plan.

Delay Cause: Needed more time to debug and fix layouts.

@enso-bot
Copy link

enso-bot bot commented Mar 24, 2023

Adam Obuchowicz reports a new STANDUP for yesterday (2023-03-23):

Progress: This day was spent on fixing layouting system. Created a PR with fixes It should be finished by 2023-03-28.

Next Day: Next day I will be working on the same task. Merge the layout fixes, also check if there is still something weirdly working in vector_editor branch.

@enso-bot
Copy link

enso-bot bot commented Mar 27, 2023

Adam Obuchowicz reports a new STANDUP for the last Friday (2023-03-24):

Progress: First half of the day I was maintaining issues and did the bookclub. The second I spent mostly with Paweł, doing better fixes for the layout algorithm. It should be finished by 2023-03-28.

Next Day: Next day I will be working on the same task. Test newest Paweł's changes if they fix the problems with widget properly.

@vitvakatu vitvakatu moved this from 🔧 Implementation to 🟢 Accepted in Issues Board Apr 3, 2023
@mergify mergify bot closed this as completed in #6142 Apr 3, 2023
mergify bot pushed a commit that referenced this issue Apr 3, 2023
Fixes #5946

Adds a vector editor widget under the node. It reacts to code changes, but does not allow any editing: this will be continuously added in next tasks.

The position is often wrong due to limitations of the display object hierarchy. It should be changed anyway when [embedding into the node](#5923). But because it looks bad, it's shown only with `--featurePreview.vectorEditor` flag.

https://user-images.githubusercontent.com/3919101/227955735-f96fc23d-7e87-4042-8586-c1154523e871.mp4
@farmaazon farmaazon moved this from 🟢 Accepted to 🗄️ Archived in Issues Board Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
d-intermediate Difficulty: some prior knowledge required p-high Should be completed in the next sprint x-new-feature Type: new feature request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants