[Deps]: bump 3.16 and Node 10 minimum #396
Conversation
|
Awesome, thanks for doing this work! Just a few questions.
Excited to get this merged! |
|
Happy to help!
|
| }, | ||
| env: { | ||
| browser: false, | ||
| node: true | ||
| }, | ||
| plugins: ['node'], | ||
| rules: Object.assign({}, require('eslint-plugin-node').configs.recommended.rules, { | ||
| // add your custom rules and overrides for node files here | ||
| 'node/no-unpublished-require': 'off' |
There was a problem hiding this comment.
I've looked up this issue and still not sure why it is warning. We have glob, express, etc in devDeps 🤔
| - 'ember-lts-2.18' | ||
| - 'ember-3.1' | ||
| - 'ember-lts-3.4' | ||
| - 'ember-lts-3.8' | ||
| - 'ember-lts-3.12' |
There was a problem hiding this comment.
3.10 is the minimum for classes and decorators and 3.6 is the minimum for classes. We could install something to get us back to 3.8 but I'm not sure that is necessary if we release a new major bump
| @@ -3,7 +3,7 @@ language: node_js | |||
| sudo: false | |||
| dist: trusty | |||
| node_js: | |||
| - "8" | |||
| - "10" | |||
There was a problem hiding this comment.
This will require a major bump
| @@ -32,11 +31,8 @@ module('Integration | Changing data render test', function(hooks) { | |||
| let serverPost = this.server.create('post', { title: 'Lorem' }); | |||
| let postId = serverPost.id; | |||
|
|
|||
| await run(() => { | |||
There was a problem hiding this comment.
run isn't necessary (can't remember when though)
|
@ryanto 👋 How is this looking to you? |
|
Hi @ryanto! Do you happen to have time to give this a look? We can further iterate on ember-data work once we can get this PR merged. If not, we can temporarily patch our test suite. |
ember-data relies on external partner tests for its CI suite. The result of a new change to convert our Model class to native classes also requires the external partner tests to follow suite.
emberjs/data#7226