-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Deps]: bump 3.16 and Node 10 minimum #396
Changes from all commits
5758158
2cfdac4
64d57ff
f38b357
50bdd3f
92ca8fc
169b57a
a42313e
683f7a2
4896b3a
5048548
6626fea
a42072f
5e6392c
8fbcfdb
924472c
07106cb
f13decb
29fceed
6c3cce6
6f7453b
25d00cd
e14c550
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,7 +4,6 @@ | |
|
||
root = true | ||
|
||
|
||
[*] | ||
end_of_line = lf | ||
charset = utf-8 | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,17 +7,13 @@ jobs: | |
matrix: | ||
ember-version: | ||
- 'ember-default' | ||
- 'ember-lts-2.16' | ||
- 'ember-lts-2.18' | ||
- 'ember-3.1' | ||
- 'ember-lts-3.4' | ||
- 'ember-lts-3.8' | ||
- 'ember-lts-3.12' | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 3.10 is the minimum for classes and decorators and 3.6 is the minimum for classes. We could install something to get us back to 3.8 but I'm not sure that is necessary if we release a new major bump |
||
- 'ember-lts-3.16' | ||
- 'ember-release' | ||
- 'ember-beta' | ||
- 'ember-canary' | ||
env: | ||
CI: true | ||
CI: true | ||
EMBER_TRY_SCENARIO: ${{ matrix.ember-version }} | ||
|
||
steps: | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
'use strict'; | ||
|
||
module.exports = { | ||
extends: 'recommended' | ||
extends: 'octane' | ||
}; |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,7 +3,7 @@ language: node_js | |
sudo: false | ||
dist: trusty | ||
node_js: | ||
- "8" | ||
- "10" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This will require a major bump |
||
|
||
addons: | ||
chrome: stable | ||
|
@@ -58,17 +58,13 @@ jobs: | |
script: yarn test | ||
|
||
- stage: fastboot tests | ||
node_js: "8" | ||
node_js: "10" | ||
env: NAME=fastboot tests | ||
script: yarn test:fastboot | ||
|
||
- stage: versioned tests | ||
env: EMBER_TRY_SCENARIO=ember-lts-2.16 | ||
- env: EMBER_TRY_SCENARIO=ember-lts-2.18 | ||
- env: EMBER_TRY_SCENARIO=ember-3.1 | ||
- env: EMBER_TRY_SCENARIO=ember-lts-3.4 | ||
- env: EMBER_TRY_SCENARIO=ember-lts-3.8 | ||
- env: EMBER_TRY_SCENARIO=ember-lts-3.12 | ||
env: EMBER_TRY_SCENARIO=ember-lts-3.16 | ||
- env: EMBER_TRY_SCENARIO=ember-release | ||
- env: EMBER_TRY_SCENARIO=ember-beta | ||
- env: EMBER_TRY_SCENARIO=ember-canary | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
# How To Contribute | ||
|
||
## Installation | ||
|
||
* `git clone <repository-url>` | ||
* `cd ember-data-storefront` | ||
* `yarn install` | ||
|
||
## Linting | ||
|
||
* `yarn lint:hbs` | ||
* `yarn lint:js` | ||
* `yarn lint:js --fix` | ||
|
||
## Running tests | ||
|
||
* `ember test` – Runs the test suite on the current Ember version | ||
* `ember test --server` – Runs the test suite in "watch mode" | ||
* `ember try:each` – Runs the test suite against multiple Ember versions | ||
|
||
## Running the dummy application | ||
|
||
* `ember serve` | ||
* Visit the dummy application at [http://localhost:4200](http://localhost:4200). | ||
|
||
For more information on using ember-cli, visit [https://ember-cli.com/](https://ember-cli.com/). |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,9 @@ | ||
import DS from 'ember-data'; | ||
import Model, { attr, hasMany, belongsTo } from '@ember-data/model'; | ||
|
||
export default DS.Model.extend({ | ||
export default class AuthorModel extends Model { | ||
@attr('string') name; | ||
|
||
name: DS.attr('string'), | ||
@hasMany() comments; | ||
@belongsTo() post; | ||
|
||
comments: DS.hasMany(), | ||
post: DS.belongsTo() | ||
|
||
}); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've looked up this issue and still not sure why it is warning. We have
glob
,express
, etc in devDeps 🤔mysticatea/eslint-plugin-node#47