Add ember-data as a peer dep #552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@snewcomer I think if we make it a peerDep, that we would want it as a devDep of just the latest version, and remove from deps. |
|
@snewcomer I wonder if we should take this opportunity to also only support ember-data |
|
Certainly! Do you see this going in a minor release or major? If the former, then we can merge and I can follow up! |
|
@snewcomer I think restricting to 3+ would mean we need a major right? |
|
I think so! I can make a follow up PR then if you think that is the right path forward. |
RobbieTheWagner
approved these changes
Sep 7, 2020
|
@snewcomer sure thing, will merge this one for now. Please do feel free to follow up. |
This was referenced Sep 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/embermap/ember-data-storefront/pull/396/checks?check_run_id=1079154106
Looking at a build error for what I assume is b/c ember-data is not listed as a peer dep (to allow the consuming library to specify). Also, if it is a peer dep, does it require as a dependency as well (currently in the
dependenciesblock as well)?Another solution might be adding "ember-data" to a resolutions block in the repo above.
Let me know what you think!