Collapse deprecations by default #885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobbieTheWagner
approved these changes
Nov 11, 2018
|
@thorsteinsson it looks like we have some test failures, potentially because tests expect things to be expanded. Can we tweak and fix the tests, as well as add tests for both the expanded and collapsed states? |
|
It's just the promise test that's failing and will be solved by #848. |
|
@thorsteinsson it's not the promise tests, it's deprecation tab tests that are failing here. They expect things to be expanded and are looking for elements that are not there. We need to tweak the tests to toggle expanding first. |
|
Good point, I fixed the tests. |
cyril-sf
pushed a commit
to cyril-sf/ember-inspector
that referenced
this pull request
Mar 30, 2022
* Collapse deprecations by default, fixes emberjs#454 * Expand deprecations in test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Collapse deprecations by default, fixes #454.
I think it's better to get an overview of all the deprecations in the app and be able to expand each one.