Collapse deprecations by default (emberjs#885)

* Collapse deprecations by default, fixes emberjs#454 * Expand deprecations in test
cyril-sf · Mar 30, 2022 · c6dfca7 · c6dfca7
1 parent 1cffa84
commit c6dfca7
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/app/components/deprecation-item.js b/app/components/deprecation-item.js
@@ -2,7 +2,7 @@ import Component from '@ember/component';
 import { notEmpty } from '@ember/object/computed';
 
 export default Component.extend({
-  isExpanded: true,
+  isExpanded: false,
 
   tagName: '',
 

diff --git a/tests/acceptance/deprecation-test.js b/tests/acceptance/deprecation-test.js
@@ -71,6 +71,8 @@ module('Deprecation Tab', function(hooks) {
 
     await visit('/deprecations');
 
+    await click('.js-deprecation-item');
+
     assert.dom('.js-deprecation-source').doesNotExist('no sources');
     assert.dom(findAll('.js-deprecation-message')[0]).hasText('Deprecation 1', 'message shown');
     assert.dom(findAll('.js-deprecation-count')[0]).hasText('2', 'Count correct');
@@ -96,6 +98,8 @@ module('Deprecation Tab', function(hooks) {
 
     await visit('/deprecations');
 
+    await click('.js-deprecation-item');
+
     assert.dom('.js-deprecation-message').hasText('Deprecation 1', 'message shown');
     assert.dom('.js-deprecation-count').hasText('2', 'Count correct');
     assert.dom('.js-deprecation-full-trace').doesNotExist('Full trace button not shown');
@@ -142,6 +146,8 @@ module('Deprecation Tab', function(hooks) {
 
     await visit('/deprecations');
 
+    await click('.js-deprecation-item');
+
     assert.dom('.js-deprecation-message').hasText('Deprecation 1', 'message shown');
     assert.dom('.js-deprecation-count').hasText('2', 'Count correct');
     assert.dom('.js-deprecation-full-trace').doesNotExist('Full trace button not shown');
@@ -189,6 +195,8 @@ module('Deprecation Tab', function(hooks) {
 
     await visit('/deprecations');
 
+    await click('.js-deprecation-item');
+
     let sources = findAll('.js-deprecation-source');
     assert.equal(sources.length, 2, 'shows all sources');
 
@@ -197,6 +205,7 @@ module('Deprecation Tab', function(hooks) {
     assert.equal(sources.length, 0, 'sources filtered');
 
     await click('.js-search-field-clear-button');
+    await click('.js-deprecation-item');
     sources = findAll('.js-deprecation-source');
     assert.equal(sources.length, 2, 'show all sources');
   });