Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collapse deprecations by default #454

Closed
Panman82 opened this issue Aug 18, 2015 · 7 comments · Fixed by #885
Closed

Collapse deprecations by default #454

Panman82 opened this issue Aug 18, 2015 · 7 comments · Fixed by #885
Assignees

Comments

@Panman82
Copy link

It's kind of annoying that deprecations are expanded when opening the tab. Makes it tough to just zip through the list to get a sense of them all, and there is already a badge for the number of instances of a particular deprecation.

Along with that, there is a weird viewing issue where if the instances list is longer than the window, it (somewhat) hides the list, making it look like you are at the end of the deprecation list. Probably worthy of a separate issue...

@teddyzeenny
Copy link
Contributor

Would a "collapse all" button solve this problem?

@Panman82
Copy link
Author

I would say that would be a minimal solution, allows the ability to quickly collapse them all. But I was hoping for them to be collapsed by default. Collapse all / expand all buttons would be useful though.

Been a while since I had to deal with a large number of depreciations. Darn that 1.13 version... 😉

@locks
Copy link
Contributor

locks commented Sep 22, 2016

@Panman8201 are you able to PR something?

@Panman82
Copy link
Author

Not at the moment, mid (major) project. I'll add it to my open source TODO list. Lot's of stuff, so little time. 😦

@locks
Copy link
Contributor

locks commented Jan 3, 2017

@Panman8201 and now? 👼

@Panman82
Copy link
Author

Panman82 commented Jan 3, 2017

@locks I think I could get a PR started for this, looks fairly straight. What is the best approach to communicate to all the child {{deprecation-item}} component instances? Kind of like actions-down.

@Panman82
Copy link
Author

Panman82 commented Jan 4, 2017

thorsteinsson added a commit to thorsteinsson/ember-inspector that referenced this issue Nov 10, 2018
@thorsteinsson thorsteinsson self-assigned this Nov 10, 2018
RobbieTheWagner pushed a commit that referenced this issue Dec 3, 2018
* Collapse deprecations by default, fixes #454

* Expand deprecations in test
cyril-sf pushed a commit to cyril-sf/ember-inspector that referenced this issue Mar 30, 2022
* Collapse deprecations by default, fixes emberjs#454

* Expand deprecations in test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants