fix: normalizeErrorResponse should be resilient to non-string details #8621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e ends up returning [object Object] for "detail"
runspired
reviewed
May 25, 2023
runspired
approved these changes
May 25, 2023
runspired
added
🎯 beta
runspired
approved these changes
May 25, 2023
runspired
changed the title
runspired
pushed a commit
that referenced
this pull request
Jun 10, 2023
#8621) * There are cases where payload is an object, and normalizeErrorResponse ends up returning [object Object] for "detail" * Add comment about JSON.stringify * Update rest.ts
runspired
added a commit
that referenced
this pull request
Jun 10, 2023
* fix: restore Store extends EmberObject :( (#8594) * fix: restore Store extends EmberObject :( * fix EmberObject bs * fix: LegacyHandler should provide unfrozen options to Adapters (resolves #8576) --------- Co-authored-by: Chris Thoburn <[email protected]> * fix: dont share promise cache for all fields (#8597) * fix: docs generation should maintain a stable relative path (#8598) * docs: fix forgotten references to FetchManager (#8601) * Avoid unnecessary identity notification when record is saved (#8566) * Add failing test * Ignore JetBrains IDE files * Revise failing test * Call setRecordId only for new records * Add (failing) test for updated id from server * update test * error when appropriate, thread context to give cache responsibility * fix lint --------- Co-authored-by: Chris Thoburn <[email protected]> * fix backport of identity notification fix * There are cases where payload is an object, and normalizeErrorRespons… (#8621) * There are cases where payload is an object, and normalizeErrorResponse ends up returning [object Object] for "detail" * Add comment about JSON.stringify * Update rest.ts --------- Co-authored-by: Maxim <[email protected]> Co-authored-by: Robby Morgan <[email protected]> Co-authored-by: NullVoxPopuli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e ends up returning [object Object] for "detail"
Description
Found this while debugging an error I was getting from Mirage (500).
It seems Mirage doesn't have a way to serialize errors -- so.. that's fun.
In any case, I think giving a best-effort attempt to show more details for the detail part of the normalizeErrorResponse return object would be beneficial for everyone.
Notes for the release
When 500 errors send an object back to the client, that object will be serialized JSON instead of
[object Object]