Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix forgotten references to FetchManager #8601

Merged
merged 1 commit into from
May 17, 2023
Merged

Conversation

runspired
Copy link
Contributor

We initially referred to RequestManager as FetchManager to help illuminate its role as decoration over fetch. But because requests can be fulfilled from any source and not just fetch we ultimately opted to call it RequestManager.

@runspired runspired added 🎯 beta PR should be backported to beta 🎯 release PR should be backported to release 🎯 canary PR is targeting canary (default) 🏷️ doc This PR adds/improves/or fixes documentation lts-4-12 Long Term LTS Maintenance labels May 8, 2023
@runspired runspired merged commit 5fb79db into main May 17, 2023
@delete-merged-branch delete-merged-branch bot deleted the cleanup-docs branch May 17, 2023 02:41
@runspired runspired removed the lts-4-12 Long Term LTS Maintenance label May 24, 2023
runspired added a commit that referenced this pull request Jun 10, 2023
* fix: restore Store extends EmberObject :( (#8594)

* fix: restore Store extends EmberObject :(

* fix EmberObject bs

* fix: LegacyHandler should provide unfrozen options to Adapters (resolves #8576)


---------

Co-authored-by: Chris Thoburn <[email protected]>

* fix: dont share promise cache for all fields (#8597)

* fix: docs generation should maintain a stable relative path (#8598)

* docs: fix forgotten references to FetchManager (#8601)

* Avoid unnecessary identity notification when record is saved (#8566)

* Add failing test

* Ignore JetBrains IDE files

* Revise failing test

* Call setRecordId only for new records

* Add (failing) test for updated id from server

* update test

* error when appropriate, thread context to give cache responsibility

* fix lint

---------

Co-authored-by: Chris Thoburn <[email protected]>

* fix backport of identity notification fix

* There are cases where payload is an object, and normalizeErrorRespons… (#8621)

* There are cases where payload is an object, and normalizeErrorResponse ends up returning [object Object] for "detail"

* Add comment about JSON.stringify

* Update rest.ts

---------

Co-authored-by: Maxim <[email protected]>
Co-authored-by: Robby Morgan <[email protected]>
Co-authored-by: NullVoxPopuli <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎯 beta PR should be backported to beta 🎯 canary PR is targeting canary (default) 🎯 release PR should be backported to release 🏷️ doc This PR adds/improves/or fixes documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants