Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: normalizeErrorResponse should be resilient to non-string details #8621

Merged
merged 3 commits into from
May 25, 2023
Merged

fix: normalizeErrorResponse should be resilient to non-string details #8621

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dab59a0
There are cases where payload is an object, and normalizeErrorRespons…
NullVoxPopuli May 25, 2023
bc79835
Add comment about JSON.stringify
NullVoxPopuli May 25, 2023
7cc88d8
Update rest.ts
NullVoxPopuli May 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/adapter/src/rest.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1276,7 +1276,11 @@ class RESTAdapter extends Adapter.extend(BuildURLMixin) {
{
status: `${status}`, // Set to a string per the JSON API spec: https://jsonapi.org/format/#errors
title: 'The backend responded with an error',
detail: `${payload}`,
// Detail is intended to be a string, but backends be non-compliant.
// stringifying gives the user a more friendly error in this situation, whereas
// they'd instead receive [object Object].
// JSON.stringify will convert *anything* to a string without erroring.
detail: typeof payload === 'string' ? payload : JSON.stringify(payload),
},
];
}
Expand Down