Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup: move @ember/string to ember-data peer-dependencies #8423

Merged
merged 2 commits into from
Feb 25, 2023
Merged

cleanup: move @ember/string to ember-data peer-dependencies #8423

merged 2 commits into from
Feb 25, 2023

Conversation

runspired
Copy link
Contributor

resolves #8393

@runspired runspired added 🎯 canary PR is targeting canary (default) 🏷️ cleanup This PR primarily removes deprecated functionality labels Feb 25, 2023
@runspired runspired force-pushed the fix-ember-string-deprecation branch from e301fe3 to dfb1ad6 Compare February 25, 2023 01:50
@runspired runspired mentioned this pull request Feb 25, 2023
Closed
@runspired runspired merged commit 2d50e82 into master Feb 25, 2023
@delete-merged-branch delete-merged-branch bot deleted the fix-ember-string-deprecation branch February 25, 2023 02:21
@ndekeister-us ndekeister-us mentioned this pull request Jun 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🎯 canary PR is targeting canary (default) 🏷️ cleanup This PR primarily removes deprecated functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move @ember/string to peerDep?
1 participant
@runspired