Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move @ember/string to peerDep? #8393

Closed
kategengler opened this issue Jan 6, 2023 · 6 comments · Fixed by #8423
Closed

Move @ember/string to peerDep? #8393

kategengler opened this issue Jan 6, 2023 · 6 comments · Fixed by #8423

Comments

@kategengler
Copy link
Member

In 4.10, ember-source is deprecating the internal @ember/string and pointing users to the addon @emberjs/octane-strike-team

ember-resolver uses @ember/string and will be adding the package as a peerDep. The CLI blueprint in 4.10 will have @ember/string as a dependency.

@runspired
Copy link
Contributor

It's a bug if it is not already a peer-dep, though it's also on it's way out :) Will audit and confirm

@kategengler
Copy link
Member Author

It is in dependencies here

"@ember/string": "^3.0.0",

@javve
Copy link

javve commented Jan 31, 2023

This generates thousands of warnings in our app. We would love a fix asap 😅

@kategengler
Copy link
Member Author

@javve I'm also looking forward to it being fixed; in the meantime, if you are seeing deprecations, you can use https://github.com/mixonic/ember-cli-deprecation-workflow to temporarily silence the deprecation. If you are seeing warnings about peerDeps, you can use resolutions or similar (depending on package manager) to force the latest version of @ember/string.

@javve
Copy link

javve commented Feb 1, 2023

Thanks, @kategengler! Good temporary solution!

@runspired
Copy link
Contributor

resolved by #8422 and #8423

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants