-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move @ember/string to peerDep? #8393
Comments
It's a bug if it is not already a peer-dep, though it's also on it's way out :) Will audit and confirm |
It is in dependencies here data/packages/-ember-data/package.json Line 30 in 5fdfd6a
|
This generates thousands of warnings in our app. We would love a fix asap 😅 |
@javve I'm also looking forward to it being fixed; in the meantime, if you are seeing deprecations, you can use https://github.com/mixonic/ember-cli-deprecation-workflow to temporarily silence the deprecation. If you are seeing warnings about peerDeps, you can use |
Thanks, @kategengler! Good temporary solution! |
In 4.10, ember-source is deprecating the internal @ember/string and pointing users to the addon @emberjs/octane-strike-team
ember-resolver
uses@ember/string
and will be adding the package as a peerDep. The CLI blueprint in 4.10 will have@ember/string
as a dependency.The text was updated successfully, but these errors were encountered: