cleanup: move @ember/string to ember-data peer-dependencies (#8423)

* cleanup: move @ember/string to ember-data peer-dependencies

* fix lint

package.json

@@ -38,7 +38,7 @@
     "@babel/runtime": "^7.21.0",
     "@ember/edition-utils": "^1.2.0",
     "@ember/optional-features": "^2.0.0",
-    "@ember/test-helpers": "~2.8.1",
+    "@ember/test-helpers": "^2.9.3",
     "@glimmer/component": "^1.1.2",
     "@glimmer/env": "^0.1.7",
     "@types/ember": "^4.0.3",
@@ -60,7 +60,6 @@
     "@types/ember__string": "^3.0.10",
     "@types/ember__template": "^4.0.1",
     "@types/ember__test": "^4.0.1",
-    "@types/ember__test-helpers": "^2.8.2",
     "@types/ember__utils": "^4.0.2",
     "@types/htmlbars-inline-precompile": "^3.0.0",
     "@types/qunit": "^2.19.4",
@@ -146,7 +145,7 @@
   },
   "volta": {
     "node": "19.0.0",
-    "pnpm": "7.18.0"
+    "pnpm": "7.27.1"
   },
   "packageManager": "[email protected]",
   "changelog": {
@@ -168,4 +167,4 @@
       "@embroider/[email protected]": "patches/@[email protected]"
     }
   }
-}
+}

packages/-ember-data/package.json

@@ -16,6 +16,9 @@
   },
   "author": "",
   "license": "MIT",
+  "peerDependencies": {
+    "@ember/string": "^3.0.1"
+  },
   "dependencies": {
     "@ember-data/adapter": "workspace:4.10.0-alpha.26",
     "@ember-data/debug": "workspace:4.10.0-alpha.26",
@@ -27,7 +30,6 @@
     "@ember-data/tracking": "workspace:4.10.0-alpha.26",
     "@ember-data/graph": "workspace:4.10.0-alpha.26",
     "@ember/edition-utils": "^1.2.0",
-    "@ember/string": "^3.0.1",
     "@embroider/macros": "^1.10.0",
     "@glimmer/env": "^0.1.7",
     "broccoli-merge-trees": "^4.2.0",
@@ -85,4 +87,4 @@
     "extends": "../../package.json"
   },
   "packageManager": "[email protected]"
-}
+}

packages/store/src/-private/store-service.ts

@@ -366,7 +366,7 @@ class Store {
       };
 
       // ensure that `getOwner(this)` works inside a model instance
-      setOwner(createOptions, getOwner(this));
+      setOwner(createOptions, getOwner(this)!);
       return getModelFactory(this, this._modelFactoryCache, modelName).class.create(createOptions);
     }
     assert(`You must implement the store's instantiateRecord hook for your custom model class.`);

packages/unpublished-test-infra/package.json

@@ -45,7 +45,7 @@
     "@babel/core": "^7.21.0",
     "@babel/runtime": "^7.21.0",
     "@ember/optional-features": "^2.0.0",
-    "@ember/test-helpers": "~2.8.1",
+    "@ember/test-helpers": "^2.9.3",
     "@glimmer/component": "^1.1.2",
     "@glimmer/tracking": "^1.1.2",
     "@types/semver": "^7.3.13",
@@ -76,4 +76,4 @@
     "extends": "../../package.json"
   },
   "packageManager": "[email protected]"
-}
+}