Fix "data-*" attributes that were incorrectly prefixed with this
#51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, I don't think we can assume that all |
|
hmmm... wondering what would be the potential use-cases where |
|
I tend to agree with @rwjblue. This should be a configurable option. Though ideally we'd finally retire that pattern of positional Guess it's time to write a codemod to finally remove them 🤔 |
|
Agreed, like @Turbo87 pointed out, https://github.com/simplabs/ember-test-selectors-params-codemod would solve this issue. Closing this PR in favor of that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #48