-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate TransformTestSelectorParamsToHashPairs transform #151
Comments
I think this is similar to the |
as mentioned in ember-codemods/ember-no-implicit-this-codemod#51 (comment), we should write a small codemod, deprecate the pattern and then throw it away. with angle bracket syntax there is no need for this hack anymore 🎉 |
hit this because of the no-implicit-this codemod, +1 for deprecating and was happy it was an easy fix. |
As discussed in #149 doesn't work reliably in all supported version of Ember, if it breaks results in very cryptic error messages and is really a small convenience feature anyway as you can always do
instead of
anyway.
The text was updated successfully, but these errors were encountered: