Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate TransformTestSelectorParamsToHashPairs transform #151

Closed
marcoow opened this issue Nov 2, 2017 · 5 comments · Fixed by #751
Closed

Deprecate TransformTestSelectorParamsToHashPairs transform #151

marcoow opened this issue Nov 2, 2017 · 5 comments · Fixed by #751
Assignees
Labels

Comments

@marcoow
Copy link
Member

marcoow commented Nov 2, 2017

As discussed in #149 doesn't work reliably in all supported version of Ember, if it breaks results in very cryptic error messages and is really a small convenience feature anyway as you can always do

{{foo-component data-test-foo=true}}

instead of

{{foo-component data-test-foo}}

anyway.

@Turbo87
Copy link
Collaborator

Turbo87 commented Nov 9, 2017

@marcoow as discovered in #150 it does actually work all the way down to Ember 1.11, but the other arguments RE usability still stand.

@marcoow
Copy link
Member Author

marcoow commented Nov 9, 2017

I think this is similar to the testSelector helper that we had - it adds complexity for very little value.

@Turbo87
Copy link
Collaborator

Turbo87 commented Dec 14, 2019

as mentioned in ember-codemods/ember-no-implicit-this-codemod#51 (comment), we should write a small codemod, deprecate the pattern and then throw it away.

with angle bracket syntax there is no need for this hack anymore 🎉

@Turbo87
Copy link
Collaborator

Turbo87 commented Dec 15, 2019

https://github.com/simplabs/ember-test-selectors-params-codemod

@runspired
Copy link

hit this because of the no-implicit-this codemod, +1 for deprecating and was happy it was an easy fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants