'data-test-' attributes are incorrectly prefixed with 'this' for curly bracket components

[chbonser]

data-test- attributes are prefixed with this for curly bracket invoked components. Example diff:

-{{#paper-card data-test-job-profile-status as |card|}}
+{{#paper-card this.data-test-job-profile-status as |card|}}

The same attributes are handled properly for angle bracket invoked components.

I suppose I could run https://github.com/ember-codemods/ember-angle-brackets-codemod first. If that is the expectation then perhaps adding a note to the readme would be called for.

[suchitadoshi1987]

@chbonser Could you confirm if this is happening only for valueless data params?

[chbonser]

@suchitadoshi1987, you are correct.

[suchitadoshi1987]

@chbonser #51 should fix that issue

[suchitadoshi1987]

@chbonser try setting the flag --dontAssumeThis=true when you are running the codemod, that would potentially fix the issue too

[Turbo87]

@suchitadoshi1987 @chbonser https://github.com/simplabs/ember-test-selectors-params-codemod 😉

[suchitadoshi1987]

oh... that's even better :). Thank you @Turbo87

[chbonser]

That's great. Thanks @Turbo87