Use strings instead of symbols to identify formatters. #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelpj
added a commit
to michaelpj/lsp-haskell
that referenced
this pull request
Sep 18, 2020
This does two things: - Create `defcustom` variables for settings, matching the vscode extension for all the language server settings. - Use `lsp-mode`'s support for custom settings to handle sending them to the server. This lets users persistently configure their server settings using normal Emacs setting customization. This will probably break people, so should maybe be a major version bump. Fixes emacs-lsp#69, emacs-lsp#75, emacs-lsp#78; supersedes the (excellent) emacs-lsp#74 and emacs-lsp#76. Notes: - I have not copied the settings from the vscode extension regarding starting the server. We don't try and get prebuilt binaries, so I thought it was simplest to stick to command-and-arguments. - I renamed the process option for consistency with other servers and to avoid references to `hie`. This PR will already break basically everyone, so I thought I might as well do that too. - The current customization functions re-send a `didChangeConfiguration` notification when called. `lsp-mode` does *not* currently do this when you change variables, which is annoying. My inclination is to let them fix it in the name of simplicity, but if anyone really hates not being able to change the formatter without restarting the server I can try and hack something together.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #75. This seems to work for me in Emacs 27.1, as well as Emacs 26.3. Thank you!