Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable hlint on multi projects by default #69

Closed
marcellussiegburg opened this issue May 28, 2020 · 2 comments · Fixed by #79
Closed

Enable hlint on multi projects by default #69

marcellussiegburg opened this issue May 28, 2020 · 2 comments · Fixed by #79

Comments

@marcellussiegburg
Copy link

Is there a way of enabling hlint by default? I could not figure out how.
It seems there is no way of setting this within my .emacs file.
I know that I can call lsp-haskell-set-hlint-on on every file or setting file-local-variables (maybe even dir-local-variables?, though being unable to setting it up); but I want hlint being enabled always anyway.

@walseb
Copy link

walseb commented May 28, 2020

Strange, on my PC it's always on by default. But if you want to run that in every new buffer you could probably just do (add-hook 'haskell-mode-hook 'lsp-haskell-set-hlint-on)

@marcellussiegburg
Copy link
Author

Thank you very much. After trying different files I figured out the issue seems to persists with multi projects only, i.e. projects using a hie.yaml. Other projects work as expected.

@marcellussiegburg marcellussiegburg changed the title Enable hlint by default Enable hlint on multi projects by default May 29, 2020
michaelpj added a commit to michaelpj/lsp-haskell that referenced this issue Sep 18, 2020
This does two things:
- Create `defcustom` variables for settings, matching the vscode
extension for all the language server settings.
- Use `lsp-mode`'s support for custom settings to handle sending them to
the server.

This lets users persistently configure their server settings using
normal Emacs setting customization.

This will probably break people, so should maybe be a major version
bump.

Fixes emacs-lsp#69, emacs-lsp#75, emacs-lsp#78; supersedes the (excellent) emacs-lsp#74 and emacs-lsp#76.

Notes:
- I have not copied the settings from the vscode extension regarding
starting the server. We don't try and get prebuilt binaries, so I
thought it was simplest to stick to command-and-arguments.
- I renamed the process option for consistency with other servers and to
avoid references to `hie`. This PR will already break basically everyone, so
I thought I might as well do that too.
- The current customization functions re-send a `didChangeConfiguration`
notification when called. `lsp-mode` does *not* currently do this when
you change variables, which is annoying. My inclination is to let them
fix it in the name of simplicity, but if anyone really hates not being
able to change the formatter without restarting the server I can try and
hack something together.
@alanz alanz closed this as completed in #79 Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants