Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for HLS versions >=0.2.2 #74

Closed
wants to merge 3 commits into from

Conversation

shaunplee
Copy link

@shaunplee shaunplee commented Jul 27, 2020

Addresses issue #73 to support HLS >=0.2.2 while trying to retain existing behavior for everything else.

Also, I'm new to elisp and open source. Please let me know if I've done something wrong.

@shaunplee
Copy link
Author

Perhaps no longer needed due to: haskell/haskell-language-server#243

@shaunplee shaunplee closed this Jul 28, 2020
@shaunplee
Copy link
Author

Actually, this might eventually be needed, per the CHANGELOG in this commit
haskell/haskell-language-server@e44f618

This changes the configuration section from "languageServerHaskell" to "haskell" to align it with vscode-haskell-1.0.0. Whilst the old section is still supported for now, you should update your LSP configuration (which varies per client) from

{
  "languageServerHaskell": {
    "formattingProvider": "stylish-haskell"
  }
}

to

{
  "haskell": {
    "formattingProvider": "stylish-haskell"
  }
}

@shaunplee shaunplee reopened this Jul 28, 2020
michaelpj added a commit to michaelpj/lsp-haskell that referenced this pull request Sep 18, 2020
This does two things:
- Create `defcustom` variables for settings, matching the vscode
extension for all the language server settings.
- Use `lsp-mode`'s support for custom settings to handle sending them to
the server.

This lets users persistently configure their server settings using
normal Emacs setting customization.

This will probably break people, so should maybe be a major version
bump.

Fixes emacs-lsp#69, emacs-lsp#75, emacs-lsp#78; supersedes the (excellent) emacs-lsp#74 and emacs-lsp#76.

Notes:
- I have not copied the settings from the vscode extension regarding
starting the server. We don't try and get prebuilt binaries, so I
thought it was simplest to stick to command-and-arguments.
- I renamed the process option for consistency with other servers and to
avoid references to `hie`. This PR will already break basically everyone, so
I thought I might as well do that too.
- The current customization functions re-send a `didChangeConfiguration`
notification when called. `lsp-mode` does *not* currently do this when
you change variables, which is annoying. My inclination is to let them
fix it in the name of simplicity, but if anyone really hates not being
able to change the formatter without restarting the server I can try and
hack something together.
@shaunplee shaunplee closed this Sep 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant