Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client gets stuck with invites even after they get rejected #3743

Closed
richvdh opened this issue Apr 26, 2017 · 18 comments
Closed

client gets stuck with invites even after they get rejected #3743

richvdh opened this issue Apr 26, 2017 · 18 comments
Labels
P1 S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Z-Mozilla Z-Synapse

Comments

@richvdh
Copy link
Member

richvdh commented Apr 26, 2017

if we can't reach a remote server when rejecting an invite, we just flag it as rejected locally. But it looks like we forget to update the client (via /sync).

Workaround is to flush the cache in the client.

@lampholder lampholder added T-Defect P1 S-Minor Impairs non-critical functionality or suitable workarounds exist labels Apr 27, 2017
@richvdh
Copy link
Member Author

richvdh commented May 2, 2017

this is a synapse bug really

@richvdh
Copy link
Member Author

richvdh commented May 2, 2017

matrix-org/synapse#2181

@rschulman
Copy link
Contributor

I have an instance of what I presume is this. Stuck invite, can't join or reject it. Its just sitting in my room list and making Riot display a notification bubble constantly. I run my own homeserver. Any way to kill it?

@t3chguy
Copy link
Member

t3chguy commented Oct 17, 2017

@rschulman after you reject it (and fail), clear client cache
there is a known bug where Synapse doesn't inform you about the reject in the Sync stream

@aaronraimist
Copy link
Collaborator

While we wait for this to be fixed in Synapse, Riot should just remove that room from its own database when I click reject. This is what Quaternion does and it means that at least you don't have to clear cache on all of your devices, you just have to click reject on all of your devices.

@t3chguy
Copy link
Member

t3chguy commented Jul 1, 2019

I'll look into this shortly

@scottwallacesh
Copy link

Any progress?

@t3chguy
Copy link
Member

t3chguy commented Jan 22, 2020

As for the workaround at this level, its too ambiguous in the case of what happens when a real re-invite comes through. This issue is blocked on Synapse fixing their issue.

@benbucksch
Copy link

benbucksch commented Feb 21, 2020

Description

I logged in to my account after a months long absence. I've had used riot only once briefly. After logging in, I see an invitation from somebody. But I cannot dismiss it. Every action says that the room has been deleted. But the invitation does not go away, no matter what I do.

Steps to reproduce

I received a chat invitation from @mwyraz:matrix.org . I have no idea whether that's a spammer or a legitimate open-source developer who wanted to contact me. I have no idea when the invitation happened.

Actual results:

  • I see 3 buttons:
    • [Start chatting]
    • [Reject & Ignore user]
    • [Reject] / [Ablehnen]
  • After I click on them, all of them show that the action failed, because:
    • the room is unknown
    • the server is unknown
    • or the action just stalls without result
  • What makes this bug serious is that none of the actions result in the invitation being removed. No matter what I do, the invitation stays. I cannot remove it.
  • The invitation shown very prominently both at the start page (literally "front and center") and prominently at the top right, above the room list. Very annoying.

Expected result:

  • Invitation does not show, if the room has been removed. OR:
  • Invitation is removed, after I click on one of the options and the system notices that the room has been removed. At least at this point, the invitation should be removed.
  • The invitation should definitely be removed, if I click "Reject". But that does not happen.

Screenshots:

After I log in:
image

After I click [Reject], the UI stalls (forever, so I need to refresh the browser page):
image

After I click [Start chatting], I get "No known servers":
image

After I click [Reject and Ignore], I get "Unknown room":
image

In my user settings, tab Security and Privacy, I found an option "Reject all 1 invitations". That button has no effect, either. It refreshes, but stays with 1 invitation.
image

Version information

  • Platform: web (in-browser)
    For the web app:
  • Browser: Firefox trunk
  • OS: Ubuntu
  • URL: riot.im/app

Importance

This is a pretty serious issue. And a bug that shows "front and center" for new users.

Can this be fixed, please? If this needs to be fixed upstream, then please submit a patch there.

@t3chguy
Copy link
Member

t3chguy commented Feb 21, 2020

@benbucksch the upstream issue you want to track is matrix-org/synapse#2181

@t3chguy t3chguy removed their assignment Mar 9, 2020
@jryans jryans added Z-Mozilla and removed Z-Community-PR Issue is solved by a community member's PR labels Mar 11, 2020
@aviau
Copy link

aviau commented Apr 6, 2020

Also getting this issue on riot.im:

Screenshot from 2020-04-05 23-56-51
Screenshot from 2020-04-05 23-56-57

The body of the network response:
{"errcode":"M_FORBIDDEN","error":"No create event in auth events"}

Its really annoying because I can't get rid of this invite:

Screenshot from 2020-04-05 23-58-48

@t3chguy
Copy link
Member

t3chguy commented Apr 6, 2020

@aviau clear client cache in settings after hitting Reject. This is a Synapse bug.

@Dragnucs
Copy link

Dragnucs commented May 3, 2020

@t3chguy where do you clear this cache from the web client at riot.im/app?

@t3chguy
Copy link
Member

t3chguy commented May 3, 2020

Settings > Help & About

@tomusdrw
Copy link

This bug is really annoying and can one's life miserable if you get spammed by room invites (just saying). Any progress or estimates when it would be addressed?

@t3chguy
Copy link
Member

t3chguy commented Jun 18, 2020

As per above, the issue is upstream: matrix-org/synapse#2181

@richvdh
Copy link
Member Author

richvdh commented Jul 9, 2020

fixed by matrix-org/synapse#7804

@justdave
Copy link

Was still seeing this in Element/android... here's my workaround to get rid of it.

In my case, I had both the invite message that wouldn't go away and a working DM window with the same person.

In Riot/web (or desktop):

  1. go to the working DM window (or any window if you didn't have a working one with that person)
  2. type /devtools and hit Enter
  3. in the popup, click on Explore Account Data
  4. click on m.direct
  5. scroll to the bottom and click Edit
  6. find the person in question in the list. In my case, they had two room hashes listed under them. If you never had a real DM window with that person there'll only be one.
  7. If you never had a working DM window with that person, just remove their entry.
  8. If you did (like I did), look at the top right corner for the room ID (since you were in the working one when you ran devtools). Do NOT remove that one, but remove the other from that person's list.
  9. Click Send at the bottom.

Make sure you keep valid JSON syntax when editing it (beware of commas, etc).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Z-Mozilla Z-Synapse
Projects
None yet
Development

Successfully merging a pull request may close this issue.