Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot reject invite to empty room #4374

Closed
MoritzFago opened this issue Jun 20, 2017 · 17 comments
Closed

Cannot reject invite to empty room #4374

MoritzFago opened this issue Jun 20, 2017 · 17 comments
Labels
Help Wanted Extra attention is needed P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect

Comments

@MoritzFago
Copy link

Description

Cannot reject invite to empty room.

Steps to reproduce

  • Get invited to a chat or into a room
  • Room/chat ceases to exist, because everyone leaves
  • You can neither accept nor decline the invitation

Describe how what happens differs from what you expected.
The decline button should remove the invitation regardless of room status. It is unacceptable that there are "ghost" invitations.

Log: sent/not sent?

Version information

  • Platform: desktop

For the desktop app:

  • OS: macOS 10.12.5
  • Version: 0.x.y
    Version of matrix-react-sdk: 0.9.6
    Version of riot-web: 0.11.3
    Version of olm: 2.2.1

initial report in synapse: matrix-org/synapse/issues/2293

@lampholder
Copy link
Member

I haven't been able to reproduce this yet.

If I:

  • create a room on my federated homeserver
  • invite sbdy from matrix.org
  • leave and forget the room
    then:
  • the invitee can just join the room (they're now the only participant)

If I:

  • create a room on matrix.org
  • invite sbdy from matrix.org
  • leave and forget the room
    then:
  • the invitee can't accept the invite 'Failed: No known servers', but they can reject it

@turt2live
Copy link
Member

@lampholder did the reject actually go through? #4225 has me a bit worried about it not going through.

@lampholder
Copy link
Member

If by 'go through' you mean "disappear from the invitee's interface", then yes, it did disappear.

@Qwertie-
Copy link

Qwertie- commented Aug 29, 2017

I just had the same issue

screenshot from 2017-08-29 21-33-26

screenshot from 2017-08-29 21-33-40

Edit: clearing the cache in riot fixed it.

@rexometer
Copy link

I have the same problem, can't accept nor decline invitation if the room does not exist anymore:

bildschirmfoto zu 2017-09-08 21-08-57

@lampholder lampholder added S-Minor Impairs non-critical functionality or suitable workarounds exist P2 and removed X-Cannot-Reproduce labels Sep 11, 2017
@lampholder
Copy link
Member

Okay, so it looks like it's still happening (event though I can't reproduce it reliably) - P2 minor because it doesn't seem to be happening a lot and can be worked around by refreshing the cache, but it is pretty smelly :(

@rexometer
Copy link

Hi @lampholder thanks for your answer! What do you mean with "can be worked around by refreshing the cache"? Refreshing the cache in the vector client didn't solve it. Is there another way to delete the invitations? For example in the database? If you need any more information for debugging, I'm happy to provide them.

@turt2live
Copy link
Member

I also have this in a room where the homeserver lost state, not the client. Harder to reproduce, but just as a point of information.

@lampholder
Copy link
Member

Ah @rexometer sorry - I was basing that on @Qwertie- 's statement that refreshing the cache fixed their problem - it could well be that there are multiple classes of problem here and that client cache refreshing can't fix all of them :(

@richvdh
Copy link
Member

richvdh commented Sep 28, 2017

If clearing the riot cache fixes it, it's #3743 / matrix-org/synapse#2181

@justfortherec
Copy link

I have had a similar looking issue with one invite for a long time. I believe the room I am invited too doesn't exist anymore (or is empty).

Flushing cache through the button in settings does not resolve the issue on my side.

#2341 would be a good enough solution for me.

@lampholder
Copy link
Member

Since it sounds like some of these invites can't be gotten rid of at all I think that warrants a higher priority.

@lampholder lampholder added S-Major Severely degrades major functionality or product features, with no satisfactory workaround P1 Help Wanted Extra attention is needed and removed S-Minor Impairs non-critical functionality or suitable workarounds exist P2 labels Oct 24, 2017
@Half-Shot
Copy link
Member

Can also confirm I am now having this with an invite.
image

@t3chguy
Copy link
Member

t3chguy commented Jan 29, 2018

@Half-Shot clear cache
and it'll magically go away :)

@Half-Shot
Copy link
Member

It did indeed :3

@richvdh
Copy link
Member

richvdh commented Jan 29, 2018

If clearing the riot cache fixes it, it's #3743 / matrix-org/synapse#2181

@richvdh
Copy link
Member

richvdh commented Apr 27, 2018

so we think this is a dup of #3743.

@richvdh richvdh closed this as completed Apr 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Help Wanted Extra attention is needed P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect
Projects
None yet
Development

No branches or pull requests

9 participants