This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Perform a local rejection for failed invite rejections, #3167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
which synapse does not send its own local-rejection down sync Signed-off-by: Michael Telatynski <[email protected]>
|
This fix has swiftly become quite messy :(( |
Signed-off-by: Michael Telatynski <[email protected]>
Signed-off-by: Michael Telatynski <[email protected]>
|
I'm going to expand on this by implementing a method in the various js-sdk stores to "locallyRejectInvite" so that there's 0 chance of a race condition with nextBatch |
|
Any news on this? Thanks for looking into it :) |
|
I wrote some code but it had a lot of edge cases where it would come back. I think implementing it more as an ignore invites from room X would be clearer in behaviour. |
|
ah I see, but then one would want to cancel ignores somehow I suppose? |
|
Synapse fixed the stuck invite bug 🎉 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
which synapse does not send its own local-rejection down sync
Fixes element-hq/element-web#3743
Signed-off-by: Michael Telatynski [email protected]