Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conditionally hide room list tabs #6770

Closed
Tracked by #6502
germain-gg opened this issue Aug 8, 2022 · 3 comments · Fixed by #7022
Closed
Tracked by #6502

Conditionally hide room list tabs #6770

germain-gg opened this issue Aug 8, 2022 · 3 comments · Fixed by #7022
Assignees
@fedrunov
Labels
T-Defect Something isn't working: bugs, crashes, hangs and other reported problems Z-AppLayout

Comments

@germain-gg
Copy link
Contributor

germain-gg commented Aug 8, 2022 •
edited
Loading

Follow the same implementation as on iOS, view element-hq/element-ios#6533

Steps to reproduce

  1. Switch to an empty space

Outcome

What did you expect?

Because you have no favourite, nor people, those two tabs should be hidden, and only displayed when they have 1+ items in there

What happened instead?

They were both displayed

Your phone model

No response

Operating system version

No response

Application version and app store

No response

Homeserver

No response

Will you send logs?

No

Are you willing to provide a PR?

No
@germain-gg germain-gg added the T-Defect Something isn't working: bugs, crashes, hangs and other reported problems label Aug 8, 2022
@daniellekirkwood
Copy link
Contributor

daniellekirkwood commented Aug 16, 2022 •
edited
Loading

Also found today:

janne |
Start first dm/Remove last dm |
If a space has no DMs, but another space has DMs, the people tab shows nonetheless |
Create a DM in space A. Switch to space B, which has no DMs. People tab will be shown. Screenshot A: https://i.k8r.eu/WJA-VQ.png Screenshot B: https://i.k8r.eu/UDui0g.png

This was referenced Sep 5, 2022
Merged
Closed
Merged
Closed
@ericdecanini
Copy link
Contributor

@fedrunov this is now fixed if I'm not mistaken?

@fedrunov
Copy link
Contributor

fedrunov commented Sep 6, 2022

@fedrunov this is now fixed if I'm not mistaken?

PR is open - #6770 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fedrunov fedrunov

Labels
T-Defect Something isn't working: bugs, crashes, hangs and other reported problems Z-AppLayout
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

hide favourites and dms filters for a selected space, if they are empty element-hq/element-android
4 participants
@germain-gg @ericdecanini @fedrunov @daniellekirkwood