Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hide favourites and dms filters for a selected space, if they are empty #7022

Merged
merged 1 commit into from
Sep 6, 2022
Merged

hide favourites and dms filters for a selected space, if they are empty #7022

merged 1 commit into from
Sep 6, 2022

Conversation

fedrunov
Copy link
Contributor

@fedrunov fedrunov commented Sep 6, 2022

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

favourites and dms filter tabs should not be shown if there is no content for them for selected space

Motivation and context

closes #6770

Screenshots / GIFs

output-optimised

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 6, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@fedrunov fedrunov added the Z-NextRelease For issues and PRs which should be included in the NextRelease. label Sep 6, 2022
bmarty
bmarty approved these changes Sep 6, 2022
View reviewed changes
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one question: does this change impact the app when the new app layout feature is disabled? I do not think so, just reading the code, but just to double check.

@fedrunov
Copy link
Contributor Author

fedrunov commented Sep 6, 2022

LGTM, just one question: does this change impact the app when the new app layout feature is disabled? I do not think so, just reading the code, but just to double check.

When App Layout is not enabled we show RoomListFragment and RoomListViewModel so it won't be affected by these changes

@bmarty
Copy link
Member

bmarty commented Sep 6, 2022

OK, thanks for explaining, I was not sure that this was distinct code.

@bmarty bmarty merged commit b3eac52 into develop Sep 6, 2022
@bmarty bmarty deleted the feature/nfe/app_layout_hide_filters_for_space branch September 6, 2022 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericdecanini ericdecanini ericdecanini approved these changes

@bmarty bmarty bmarty approved these changes

Assignees
No one assigned
Labels
Z-NextRelease For issues and PRs which should be included in the NextRelease.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Conditionally hide room list tabs
3 participants
@fedrunov @bmarty @ericdecanini