Conditionally hide room list tabs #6533

gileluard · 2022-08-04T15:17:30Z

resolves #6515

- First implementation

# Conflicts: # Riot/Generated/UntranslatedStrings.swift

- Update after reviews

- Added new analytics

- Last tweaks

- fixed theme issues

- fixed build after merge - renamed AllChats classes

- new Build settings newAppLayoutEnaled

- Removed the Pinned space feature

- Removed the All chats layout editor screen - Added feature flag - Added context menus

- Removed analytics used for IA test

- Added Space selector bottom sheet - Changed placement for the context menus in the all chats screen

- Code tweaks

- Code cleanup

…Implement_new_Space_selector_bottom_sheet

- Update after design review

- Update after review

- Code cleanup

…Implement_new_Space_selector_bottom_sheet # Conflicts: # Riot/Modules/ContextMenu/ActionProviders/AllChatsActionProvider.swift # Riot/Modules/Home/AllChats/AllChatsViewController.swift

- Added space switching analytics - Implemented unit and UI test for space selector bottom sheet

- Animation for bottom action panel - UI tweaks

- Temporarily reintroduced invites

Co-authored-by: Doug <[email protected]>

- Update after code review

…vector-im/element-ios into gil/6079-Delight_Edit_layout_experiment

- Changed Recents type to Breadcrumbs

- Update after code review

…Implement_new_Space_selector_bottom_sheet # Conflicts: # Riot/Modules/Home/AllChats/AllChatsActionPanelView.swift # Riot/Modules/Home/AllChats/AllChatsActionPanelView.xib # Riot/Modules/Home/AllChats/AllChatsViewController.swift # Riot/Modules/TabBar/TabBarCoordinator.swift

- Do not show coach message with the new App Layout

…tom_sheet # Conflicts: # Riot/Assets/en.lproj/Vector.strings # Riot/Generated/Strings.swift # Riot/Modules/Common/Recents/DataSources/RecentsDataSource.m # Riot/Modules/Common/Recents/Service/MatrixSDK/RecentsListService.swift # Riot/Modules/Common/Recents/Service/Mock/MockRecentsListService.swift # Riot/Modules/Common/Recents/Service/RecentsListServiceProtocol.swift # Riot/Modules/ContextMenu/ActionProviders/AllChatsActionProvider.swift # Riot/Modules/Home/AllChats/AllChatsViewController.swift # Riot/Modules/Home/AllChats/AllChatsViewController.xib # Riot/Modules/TabBar/TabBarCoordinator.swift

- Removed unnecessary images - Changed for SVG format

- Now using the default toolbar of the navigation controller

- Removed the swipe actions menu in recents

- Reverted some Theme tweaks to fix some UI regressions

- Added change log - Hide toolbar when leave All Chats screen

- Implemented

pixlwave

LGTM 👍

pixlwave · 2022-08-05T09:11:52Z

Riot/Modules/Common/Recents/DataSources/RecentsDataSource.m

@@ -966,6 +966,10 @@ - (UIView *)viewForHeaderInSection:(NSInteger)section withFrame:(CGRect)frame in

        if (self.allChatsOptionsView)
        {
+            [self.allChatsFilterOptions updateWithFilterOptionListView:self.allChatsOptionsView
+                                                          unreadsCount:1 // unreads is allways visible


I'm wondering if it actually makes sense to have the unreadsCount parameter on the method if we always pass 1 to force a result?

It's clearly a matter of point of view. In my opinion, the AllChatsFilterOptions instance has to manage 3 tabs for now:
unreads, favourites, and people. For consistency purpose, this method needs the count for all those 3 tabs. Up to the caller to set the unreads tab as always visible as requested for now in the related issue.

I can change it if this makes no sense to you.

Nah its totally fine as is, was only a thought :)

# Conflicts: # Riot/Modules/Common/Recents/RecentsViewController.m # Riot/Modules/ContextMenu/ActionProviders/AllChatsEditActionProvider.swift # Riot/Modules/Home/AllChats/AllChatsViewController.swift # RiotSwiftUI/Modules/Spaces/SpaceSelectorBottomSheet/Coordinator/SpaceSelectorBottomCoordinator.swift # RiotSwiftUI/Modules/Spaces/SpaceSelectorBottomSheet/Coordinator/SpaceSelectorBottomCoordinatorBridgePresenter.swift # RiotSwiftUI/Modules/Spaces/SpaceSelectorBottomSheet/SpaceSelector/Coordinator/SpaceSelectorCoordinator.swift # RiotSwiftUI/Modules/Spaces/SpaceSelectorBottomSheet/SpaceSelector/MockSpaceSelectorScreenState.swift # RiotSwiftUI/Modules/Spaces/SpaceSelectorBottomSheet/SpaceSelector/Service/MatrixSDK/SpaceSelectorService.swift # RiotSwiftUI/Modules/Spaces/SpaceSelectorBottomSheet/SpaceSelector/Service/Mock/MockSpaceSelectorService.swift # RiotSwiftUI/Modules/Spaces/SpaceSelectorBottomSheet/SpaceSelector/Service/SpaceSelectorServiceProtocol.swift # RiotSwiftUI/Modules/Spaces/SpaceSelectorBottomSheet/SpaceSelector/SpaceSelectorModels.swift # RiotSwiftUI/Modules/Spaces/SpaceSelectorBottomSheet/SpaceSelector/SpaceSelectorViewModel.swift # RiotSwiftUI/Modules/Spaces/SpaceSelectorBottomSheet/SpaceSelector/SpaceSelectorViewModelProtocol.swift # RiotSwiftUI/Modules/Spaces/SpaceSelectorBottomSheet/SpaceSelector/Test/UI/SpaceSelectorUITests.swift # RiotSwiftUI/Modules/Spaces/SpaceSelectorBottomSheet/SpaceSelector/Test/Unit/SpaceSelectorViewModelTests.swift # RiotSwiftUI/Modules/Spaces/SpaceSelectorBottomSheet/SpaceSelector/View/SpaceSelector.swift

sonarqubecloud · 2022-08-05T12:14:34Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

github-actions · 2022-08-05T13:36:49Z

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/x2b13k

gileluard and others added 30 commits May 10, 2022 22:15

Delight: Edit layout experiment #6079

9937828

- First implementation

Merge branch 'develop' into gil/6079-Delight_Edit_layout_experiment

ad043d9

# Conflicts: # Riot/Generated/UntranslatedStrings.swift

Delight: Edit layout experiment #6079

01bf3ed

- Update after reviews

Merge branch 'develop' into gil/6079-Delight_Edit_layout_experiment

857f446

Delight: Edit layout experiment #6079

1f96dca

- Added new analytics

Merge branch 'develop' into gil/6079-Delight_Edit_layout_experiment

e58cd8f

Delight: Edit layout experiment #6079

d8e3a96

- Last tweaks

Delight: Edit layout experiment #6079

378bcd3

- fixed theme issues

Merge branch 'develop' into gil/6079-Delight_Edit_layout_experiment

5505e8c

Merge branch 'develop' into gil/6079-Delight_Edit_layout_experiment

95ca2fa

Delight: Edit layout experiment #6079

38ed032

- fixed build after merge - renamed AllChats classes

Feature flag new App Layout #6406

51b179a

- new Build settings newAppLayoutEnaled

Merge branch 'develop' into gil/6079-Delight_Edit_layout_experiment

4d3befc

Update All chats screen with latest design #6407

b01c4fe

- Removed the Pinned space feature

Update All chats screen with latest design #6407

c77a527

- Removed the All chats layout editor screen - Added feature flag - Added context menus

Update All chats screen with latest design #6407

d89e441

- Removed analytics used for IA test

Merge branch 'develop' into gil/6079-Delight_Edit_layout_experiment

bb12f9a

Implement the new Space selector bottom sheet #6410

f031dae

- Added Space selector bottom sheet - Changed placement for the context menus in the all chats screen

Implement the new Space selector bottom sheet #6410

8ecdba3

- Code tweaks

Update All chats screen with latest design #6407

7d2b5ab

- Code cleanup

Merge branch 'gil/6079-Delight_Edit_layout_experiment' into gil/6410-…

9be284e

…Implement_new_Space_selector_bottom_sheet

Implement the new Space selector bottom sheet #6410

f01abe2

- Update after design review

Update All chats screen with latest design #6407

7d03718

- Update after review

Update All chats screen with latest design #6407

2531c9c

- Code cleanup

Merge branch 'develop' into gil/6079-Delight_Edit_layout_experiment

ad7e61f

Merge branch 'gil/6079-Delight_Edit_layout_experiment' into gil/6410-…

8ff2983

…Implement_new_Space_selector_bottom_sheet # Conflicts: # Riot/Modules/ContextMenu/ActionProviders/AllChatsActionProvider.swift # Riot/Modules/Home/AllChats/AllChatsViewController.swift

Implement the new Space selector bottom sheet #6410

356a466

- Added space switching analytics - Implemented unit and UI test for space selector bottom sheet

Implement the new Space selector bottom sheet #6410

bbbfdd0

- Animation for bottom action panel - UI tweaks

Implement the new Space selector bottom sheet #6410

2e8acac

- Temporarily reintroduced invites

Update Riot/Modules/Home/AllChats/AllChatsLayoutSettingsManager.swift

6326fd0

Co-authored-by: Doug <[email protected]>

gileluard added 14 commits August 1, 2022 17:25

Update All chats screen with latest design #6407

9d3c49a

- Update after code review

Merge branch 'gil/6079-Delight_Edit_layout_experiment' of github.com:…

75bf04f

…vector-im/element-ios into gil/6079-Delight_Edit_layout_experiment

Update All chats screen with latest design #6407

cd68bae

- Changed Recents type to Breadcrumbs

Update All chats screen with latest design #6407

6e93716

- Update after code review

Update All chats screen with latest design #6407

e0856fb

- Update after code review

Implement the new Space selector bottom sheet #6410

5fcebcf

- Do not show coach message with the new App Layout

Implement the new Space selector bottom sheet #6410

da552ec

- Removed unnecessary images - Changed for SVG format

Implement the new Space selector bottom sheet #6410

e478bf4

- Now using the default toolbar of the navigation controller

Implement the new Space selector bottom sheet #6410

3a0cb7d

- Removed the swipe actions menu in recents

Implement the new Space selector bottom sheet #6410

3e18325

- Reverted some Theme tweaks to fix some UI regressions

Implement the new Space selector bottom sheet #6410

6b82b00

- Added change log - Hide toolbar when leave All Chats screen

Conditionally hide room list tabs

81b7161

- Implemented

gileluard mentioned this pull request Aug 4, 2022

Some UI tweaks for New App Layout #6535

Merged

gileluard requested a review from pixlwave August 5, 2022 08:54

pixlwave approved these changes Aug 5, 2022

View reviewed changes

Base automatically changed from gil/6410-Implement_new_Space_selector_bottom_sheet to develop August 5, 2022 11:39

gileluard marked this pull request as ready for review August 5, 2022 12:39

gileluard merged commit da27091 into develop Aug 5, 2022

gileluard deleted the gil/6515-Conditionally_hide_room_list_tabs branch August 5, 2022 12:56

germain-gg mentioned this pull request Aug 8, 2022

Conditionally hide room list tabs element-hq/element-android#6770

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Conditionally hide room list tabs #6533

Conditionally hide room list tabs #6533

gileluard commented Aug 4, 2022

pixlwave left a comment

pixlwave Aug 5, 2022 •

edited

Loading

gileluard Aug 5, 2022

pixlwave Aug 5, 2022

sonarqubecloud bot commented Aug 5, 2022

github-actions bot commented Aug 5, 2022

Conditionally hide room list tabs #6533

Conditionally hide room list tabs #6533

Conversation

gileluard commented Aug 4, 2022

pixlwave left a comment

Choose a reason for hiding this comment

pixlwave Aug 5, 2022 • edited Loading

Choose a reason for hiding this comment

gileluard Aug 5, 2022

Choose a reason for hiding this comment

pixlwave Aug 5, 2022

Choose a reason for hiding this comment

sonarqubecloud bot commented Aug 5, 2022

github-actions bot commented Aug 5, 2022

pixlwave Aug 5, 2022 •

edited

Loading