feat: adding signature-size option #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sethlu
reviewed
Oct 26, 2019
README.md
Outdated
| @@ -230,6 +230,9 @@ Restrict dyld loading. See doc about this [code signature flag](https://develope | |||
| `signature-flags` - *String* | |||
| Comma separated string or array for [code signature flag](https://developer.apple.com/documentation/security/seccodesignatureflags?language=objc). Default to `undefined`. | |||
|
|
|||
| `signature-size` - *Number* | |||
| Provide a value to be passed to `codesign` along with the `--signature-size` flag, to work around the *Signature too large to embed* issue. A value of `12000` should do it - see the [FAQ](https://github.com/electron/electron-osx-sign/wiki/FAQ) for details. Default to `undefined`. | |||
There was a problem hiding this comment.
Probably rather than having *Signature too large to embed*, we can format it as "signature too large to embed"?
sign.js
Outdated
| @@ -158,6 +158,9 @@ function signApplicationAsync (opts) { | |||
| } else { | |||
| args.push('--timestamp') | |||
| } | |||
| if (opts['signature-size'] && Number.isInteger(opts['signature-size'])) { | |||
There was a problem hiding this comment.
Perhaps we can debugwarn() some information if a signature size is provided but isn't integer-typed?
There was a problem hiding this comment.
@sethlu added debugwarn() and a minimal check for positive value.
fix: debugwarn for bad signature-size value
|
@netop 🙇 Merged, thanks for working on this feature! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to issue #207