Merge pull request #208 from netop/master

feat: adding signature-size option

README.md

@@ -224,12 +224,15 @@ Default to `undefined`.
 
 `restrict` - *Boolean*
 
-**To be deprecated, see `signature-flags`.** 
+**To be deprecated, see `signature-flags`.**
 Restrict dyld loading. See doc about this [code signature flag](https://developer.apple.com/documentation/security/seccodesignatureflags/kseccodesignaturerestrict?language=objc) for more details. Disabled by default.
 
 `signature-flags` - *String*
 Comma separated string or array for [code signature flag](https://developer.apple.com/documentation/security/seccodesignatureflags?language=objc). Default to `undefined`.
 
+`signature-size` - *Number*
+Provide a value to be passed to `codesign` along with the `--signature-size` flag, to work around the *signature too large to embed* issue. A value of `12000` should do it - see the [FAQ](https://github.com/electron/electron-osx-sign/wiki/FAQ) for details. Default to `undefined`.
+
 `strict-verify` - *Boolean|String|Array.<String>*
 
 Flag to enable/disable `--strict` flag when verifying the signed application bundle.

bin/electron-osx-sign-usage.txt

@@ -70,6 +70,9 @@ DESCRIPTION
   --signature-flags=flags
     Code signature flags. Default to none.
 
+  --signature-size=size
+    Signature size. Default to none.
+
   --strict-verify, --strict-verify=options, --no-strict-verify
     Flag to enable/disable ``--strict'' flag when verifying the signed application bundle.
     Each component should be separated in ``options'' with comma (``,'').

bin/electron-osx-sign.js

@@ -6,6 +6,9 @@ var args = require('minimist')(process.argv.slice(2), {
   'string': [
     'signature-flags'
   ],
+  'number': [
+    'signature-size'
+  ],
   'boolean': [
     'help',
     'pre-auto-entitlements',

index.d.ts

@@ -16,6 +16,7 @@ declare module "electron-osx-sign" {
     'pre-embed-provisioning-profile'?: boolean;
     'provisioning-profile'?: string;
     'requirements'?: string;
+    'signature-size'?: number;
     'type'?: string;
     version?: string;
     'identity-validation'?: boolean;

sign.js

@@ -158,6 +158,13 @@ function signApplicationAsync (opts) {
       } else {
         args.push('--timestamp')
       }
+      if (opts['signature-size']) {
+        if (Number.isInteger(opts['signature-size']) && opts['signature-size'] > 0) {
+          args.push('--signature-size', opts['signature-size'])
+        } else {
+          debugwarn(`Invalid value provided for --signature-size (${opts['signature-size']}). Must be a positive integer.`)
+        }
+      }
 
       let optionsArguments = []