Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding signature-size option #208

Merged
merged 3 commits into from
Oct 29, 2019
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -230,6 +230,9 @@ Restrict dyld loading. See doc about this [code signature flag](https://develope
`signature-flags` - *String*
Comma separated string or array for [code signature flag](https://developer.apple.com/documentation/security/seccodesignatureflags?language=objc). Default to `undefined`.

`signature-size` - *Number*
Provide a value to be passed to `codesign` along with the `--signature-size` flag, to work around the *Signature too large to embed* issue. A value of `12000` should do it - see the [FAQ](https://github.com/electron/electron-osx-sign/wiki/FAQ) for details. Default to `undefined`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably rather than having *Signature too large to embed*, we can format it as "signature too large to embed"?

Copy link
Author

@netop netop Oct 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sethlu Agreed & done 😄


`strict-verify` - *Boolean|String|Array.<String>*

Flag to enable/disable `--strict` flag when verifying the signed application bundle.
Expand Down
3 changes: 3 additions & 0 deletions bin/electron-osx-sign-usage.txt
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,9 @@ DESCRIPTION
--signature-flags=flags
Code signature flags. Default to none.

--signature-size=size
Signature size. Default to none.

--strict-verify, --strict-verify=options, --no-strict-verify
Flag to enable/disable ``--strict'' flag when verifying the signed application bundle.
Each component should be separated in ``options'' with comma (``,'').
Expand Down
3 changes: 3 additions & 0 deletions bin/electron-osx-sign.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@ var args = require('minimist')(process.argv.slice(2), {
'string': [
'signature-flags'
],
'number': [
'signature-size'
],
'boolean': [
'help',
'pre-auto-entitlements',
Expand Down
1 change: 1 addition & 0 deletions index.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ declare module "electron-osx-sign" {
'pre-embed-provisioning-profile'?: boolean;
'provisioning-profile'?: string;
'requirements'?: string;
'signature-size'?: number;
'type'?: string;
version?: string;
'identity-validation'?: boolean;
Expand Down
3 changes: 3 additions & 0 deletions sign.js
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,9 @@ function signApplicationAsync (opts) {
} else {
args.push('--timestamp')
}
if (opts['signature-size'] && Number.isInteger(opts['signature-size'])) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we can debugwarn() some information if a signature size is provided but isn't integer-typed?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sethlu added debugwarn() and a minimal check for positive value.

args.push('--signature-size', opts['signature-size'])
}

let optionsArguments = []

Expand Down