-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Canvas] Integrates Solution Toolbar #94489
Closed
cqliu1
wants to merge
53
commits into
elastic:canvas/by-value-embeddables
from
cqliu1:canvas/panel-toolbar
Closed
[Canvas] Integrates Solution Toolbar #94489
cqliu1
wants to merge
53
commits into
elastic:canvas/by-value-embeddables
from
cqliu1:canvas/panel-toolbar
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cqliu1
force-pushed
the
canvas/panel-toolbar
branch
from
March 11, 2021 20:59
5f53c71
to
01253b5
Compare
cqliu1
changed the title
[Canvas] Integrates Panel Toolbar
[Canvas] Integrates Solution Toolbar
Mar 22, 2021
cqliu1
force-pushed
the
canvas/panel-toolbar
branch
3 times, most recently
from
March 25, 2021 18:34
c9e03dd
to
fd3b0d7
Compare
cqliu1
force-pushed
the
canvas/panel-toolbar
branch
3 times, most recently
from
March 31, 2021 20:43
2afc3c2
to
2097380
Compare
cqliu1
added
Feature:Canvas
Team:Presentation
Presentation Team for Dashboard, Input Controls, and Canvas
labels
Apr 2, 2021
cqliu1
force-pushed
the
canvas/panel-toolbar
branch
from
April 2, 2021 23:24
2097380
to
8e08918
Compare
cqliu1
force-pushed
the
canvas/panel-toolbar
branch
from
April 20, 2021 21:18
8e08918
to
1734041
Compare
* Update mapColumn expression function implementation to support partial results * Add partial results example plugin
) * [Stack Monitoring] Convert setup directory to typescript * Fix types Co-authored-by: Kibana Machine <[email protected]>
elastic#112696) * [Stack Monitoring] Convert standalone_clusters directory to typescript * Fix types Co-authored-by: Kibana Machine <[email protected]>
…lastic#113031) Co-authored-by: Kibana Machine <[email protected]>
Co-authored-by: spalger <[email protected]>
* [Reporting] Stabilize CSV export tests * add debugging logging for results metadata * restore accidentally deleted tests * restore "large export" test * remove redundant availability test * do not filter and re-save * fix getHitCount * fix large export test * skip large export test :( Co-authored-by: Kibana Machine <[email protected]>
… right Y axes (elastic#113073) * [Viz] legend duplicates percentile options when chart has both left & right Y axes * Update comment for isPercentileIdEqualToSeriesId * Remove Dimension interface * Replace partial aspect with whole aspect value Co-authored-by: Kibana Machine <[email protected]>
Co-authored-by: Kibana Machine <[email protected]>
…tic#113161) Co-authored-by: Kibana Machine <[email protected]>
Co-authored-by: Kibana Machine <[email protected]>
13 tasks
cqliu1
force-pushed
the
canvas/panel-toolbar
branch
2 times, most recently
from
September 27, 2021 22:04
47f1a8a
to
0d3f883
Compare
* add `SavedObjectType.management.displayName` * fix unit tests * add FTR test * update generated doc * also update labels * fix unit tests
…lastic#112930) Co-authored-by: Kibana Machine <[email protected]>
* Beats instance page * Remove unused getPaginationRouteOptions
…ic#112849) * updated jest tests to avoid generating unhandled promise rejections * rather use throwError * remove unused imports Co-authored-by: Kibana Machine <[email protected]>
* Move workpad components to typescript * Fix types Co-authored-by: Kibana Machine <[email protected]>
Co-authored-by: Kibana Machine <[email protected]>
* [FieldFormatters] Use default values for URL formatter
* Write plugin directory doc as part of api docs build. * Replace service folder with the new name for index patterns * Updated docs * small update * update docs
* Refactor useUrlStateHooks by batching updates to location * Delete unused detail name * Delete URL_STATE_KEYS constants * Refactor useUrlStateHook * Fix cypress tests by removing empty AppQuery from URL query string Fix empty query validation by considering 'query=()' as empty * Small code readability improvements It mostly rename variables
… in our action docs (elastic#113293)
…lastic#113213) * [Alerting] Fixed Jest test suites with unhandled promise rejections * fixed typecheck
…ate dashboard button elastic#111233 (elastic#112872) * test if 2s sleep fixes flakey test * switch from sleep to retry.waitFor * remove .only, add comments to config file about sample data add/remove Co-authored-by: Kibana Machine <[email protected]>
* Remove RFCs from our repository. * Revert "Remove RFCs from our repository." This reverts commit e97e3fb. * rename folder, and update readme.
…elastic#113296) Co-authored-by: Luke Elmers <[email protected]>
Add `?*` to the end of request aliases in instances table tests. elastic#104301 upgraded Cypress to a newer version that required this, but the APM E2E tests were not run because there were no changes to any files in APM.
cqliu1
force-pushed
the
canvas/panel-toolbar
branch
from
September 28, 2021 20:40
0d3f883
to
2671699
Compare
Closed in favor of #113329. |
💔 Build Failed
Failed CI Steps
Test FailuresKibana Pipeline / jest / Jest Tests.x-pack/plugins/uptime/public/components/overview/query_bar.useQueryBar updates URL only when conditions are appropriateStandard Out
Stack Trace
Kibana Pipeline / jest / Jest Tests.x-pack/plugins/canvas/storybook.Storyshots components/WorkpadHeader/ElementMenu defaultStandard Out
Stack Trace
Kibana Pipeline / general / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/canvas/custom_elements·ts.Canvas app custom elements adds the custom element to the workpad when promptedStandard Out
Stack Trace
History
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related to #85666.
Blocked by #94139.This integrates the
SolutionToolbar
component frompresentation_util
into the Canvas workpad header and aligns the UI for adding content in Dashboard and Canvas.Checklist
Delete any items that are not applicable to this PR.
For maintainers