Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[embeddable] Don’t include test samples into initial bundle #113126

Merged
merged 2 commits into from
Sep 28, 2021

Conversation

Dosant
Copy link
Contributor

@Dosant Dosant commented Sep 27, 2021

Summary

Close #95860

This brings embeddable just under 100Kb by not including test sample data into the initial bundle as those ared used only in unit test

There are other easy improvements in embeddable plugin, but I'd look at those separately

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
embeddable 104 82 -22

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
embeddable 101.9KB 90.5KB -11.4KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@Dosant Dosant added Feature:Embedding Embedding content via iFrame release_note:skip Skip the PR/issue when compiling release notes Team:AppServicesUx v7.16.0 v8.0.0 labels Sep 28, 2021
@Dosant Dosant changed the title [embeddable] don’t include test samples [embeddable] Don’t include test samples into initial bundle Sep 28, 2021
@Dosant Dosant marked this pull request as ready for review September 28, 2021 08:23
@Dosant Dosant requested review from a team as code owners September 28, 2021 08:23
@Dosant Dosant requested a review from vadimkibana September 28, 2021 08:23
@Dosant Dosant added the auto-backport Deprecated - use backport:version if exact versions are needed label Sep 28, 2021
@Dosant Dosant merged commit 3311910 into elastic:master Sep 28, 2021
@kibanamachine
Copy link
Contributor

💔 Backport failed

Status Branch Result
7.x Commit could not be cherrypicked due to conflicts

To backport manually run:
node scripts/backport --pr 113126

Dosant added a commit to Dosant/kibana that referenced this pull request Sep 29, 2021
Dosant added a commit that referenced this pull request Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Embedding Embedding content via iFrame release_note:skip Skip the PR/issue when compiling release notes v7.16.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[embeddable] Reduce page load bundle to under 100kB
4 participants