Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Observability] Exploratory View initial skeleton #94426

Merged
merged 86 commits into from
Apr 5, 2021
Merged

[Observability] Exploratory View initial skeleton #94426

merged 86 commits into from
Apr 5, 2021

Conversation

shahzad31
Copy link
Contributor

@shahzad31 shahzad31 commented Mar 11, 2021 •
edited
Loading

Summary

Kibana-app

Created a separate PR for kibana app changes #95771

Part of https://github.com/elastic/uptime-dev/issues/46

This PR only partially addresses issue

Scope

Limiting the scope of the PR, Pushing this PR into ready state to keep it in reviewable state.

this adds exploratory view skeleton.

Also adds integration with Lens

Adds Series builder/editor components

Follow Up:

Since code is already exploding, i will do follow up PR's to use actual index patterns formatting/labels.

Also there will be another follow up to add actual integration to User Experience app viz.

image

I expect significant design iterations and workflow iterations

@shahzad31 shahzad31 mentioned this pull request Mar 15, 2021
Merged
katrin-freihofner
katrin-freihofner reviewed Mar 15, 2021
View reviewed changes
Copy link
Contributor

@katrin-freihofner katrin-freihofner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! And thank you for the demo.

I added a few comments with things we talked about and other small visual improvements.

I will think about the title, as a default, we could add the chart title from the entry point.

.../observability/public/components/shared/exploratory_view/chart_templates/chart_templates.tsx Outdated Show resolved Hide resolved
.../plugins/observability/public/components/shared/exploratory_view/header/metric_selection.tsx Outdated Show resolved Hide resolved
...observability/public/components/shared/exploratory_view/series_editor/columns/breakdowns.tsx Outdated Show resolved Hide resolved
...ervability/public/components/shared/exploratory_view/series_editor/columns/remove_series.tsx Outdated Show resolved Hide resolved
...ns/observability/public/components/shared/exploratory_view/series_editor/default_filters.tsx Outdated Show resolved Hide resolved
...ns/observability/public/components/shared/exploratory_view/series_builder/series_builder.tsx Outdated Show resolved Hide resolved
@kibanamachine
Copy link
Contributor

⏳ Build in-progress, with failures

Failed CI Steps

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

dominiqueclarke
dominiqueclarke approved these changes Mar 31, 2021
View reviewed changes
Copy link
Contributor

@dominiqueclarke dominiqueclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One thing to note is that when I opened exploratory view without apm data, a blank screen appeared, no error or help text telling me to set up apm or something like that.

@shahzad31
Copy link
Contributor Author

@elasticmachine merge upstream

@shahzad31 shahzad31 requested a review from a team as a code owner April 5, 2021 05:37
@botelastic botelastic bot added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label Apr 5, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
observability 248 299 +51

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observability 326.9KB 391.1KB +64.2KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
observability 26.6KB 35.0KB +8.4KB
uptime 18.6KB 18.6KB +23.0B
total +8.4KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @shahzad31

@shahzad31 shahzad31 merged commit a640522 into elastic:master Apr 5, 2021
@shahzad31 shahzad31 deleted the exploratry-view branch April 5, 2021 13:26
@shahzad31 shahzad31 added the auto-backport Deprecated - use backport:version if exact versions are needed label Apr 5, 2021
@kibanamachine kibanamachine mentioned this pull request Apr 5, 2021
Merged
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Apr 5, 2021
@shahzad31 @kibanamachine
[Observability] Exploratory View initial skeleton (elastic#94426)
6a0d5d7 
Co-authored-by: Kibana Machine <[email protected]>
@kibanamachine
Copy link
Contributor

💚 Backport successful

✅ 7.x / #96215

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Apr 5, 2021
@kibanamachine @shahzad31
[Observability] Exploratory View initial skeleton (#94426) (#96215)
317e1e4 
Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Shahzad <[email protected]>
jloleysens added a commit to jloleysens/kibana that referenced this pull request Apr 6, 2021
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into sr/fix-wizard…
97ee8a6 
…-nav

* 'master' of github.com:elastic/kibana: (106 commits)
  [Lens] don't use eui variables for zindex (elastic#96117)
  Remove /src/legacy (elastic#95510)
  skip flaky suite (elastic#95899)
  [Dashboard] Fix Lens and TSVB chart tooltip positioning relative to global headers (elastic#94247)
  fixes a skipped management x-pack test (elastic#96178)
  [App Search] API logs: Add log detail flyout (elastic#96162)
  [tech-debt] Remove defunct opacity parameters from EUI shadow functions (elastic#96191)
  Add Input Controls project configuration (elastic#96238)
  [file upload] document file upload privileges and provide actionable UI when failures occur (elastic#95883)
  Revert "TS Incremental build exclude test files (elastic#95610)" (elastic#96223)
  [App Search] Added Sample Response section to Result Settings (elastic#95971)
  [Maps] Safe-erase text-field (elastic#94873)
  [RAC][Alert Triage][TGrid] Update the Alerts Table (TGrid) API to implement `renderCellValue` (elastic#96098)
  [Maps] Enable all zoom levels for all users (elastic#96093)
  Use plugin version in its publicPath (elastic#95945)
  [Enterprise Search] Expose core.chrome.setIsVisible for use in Workplace Search (elastic#95984)
  [Workplace Search] Add sub nav and fix rendering bugs in Personal dashboard (elastic#96100)
  [OBS]home page is showing incorrect value of APM throughput (tpm) (elastic#95991)
  [Observability] Exploratory View initial skeleton (elastic#94426)
  [KQL] Fixed styles of KQL textarea for the K8 theme (elastic#96190)
  ...

# Conflicts:
#	x-pack/plugins/snapshot_restore/__jest__/client_integration/helpers/restore_snapshot.helpers.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katrin-freihofner katrin-freihofner katrin-freihofner left review comments

@dominiqueclarke dominiqueclarke dominiqueclarke approved these changes

Assignees

@shahzad31 shahzad31

Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.13.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@shahzad31 @kibanamachine @elasticmachine @dominiqueclarke @katrin-freihofner