Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Observability] Exploratory View initial skeleton #94426
[Observability] Exploratory View initial skeleton #94426
Changes from 75 commits
9e7c169
12c028f
b089a87
501a166
3ed7c82
c303383
73b2c41
9166efc
3783b5f
04316ab
9677edd
e715ace
5d3605f
3d824be
1db17ad
306fa3f
e2f281f
700cdd7
ee82e77
1d5a7c8
91bcf95
2ec3924
4f8f118
b2fbc2b
e5c1e59
c14a2e5
165a540
e3b3eb5
4b8aab4
84c2abe
75b87e1
533698a
f60a7f5
805f062
8952b21
68282c6
9886ef6
a2121eb
4b87ef9
ad9574f
52cbefa
a6dcd15
7af9e25
6c1a330
89d87e0
a85d735
3c670f2
d26f306
ec98c08
43887f1
967888a
8e5109f
9acecc1
082eaf4
211716b
635be8e
50e100f
dbb98c7
68d8243
1f4a516
31b60b6
0557ad3
c512b3d
e4ce7bd
1b57eff
17120a6
1710e5d
f162f96
c43e925
adfefa3
e004a7a
01a1559
5406e75
2b5229b
f894f18
7050460
06f305b
62070d4
9090e64
3e29da3
25c45e0
c18c829
99d3596
679a4a8
9c86621
7e5cf29
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why no exhaustive deps here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i am using a weird technique here, lens attribute is a huge object so using JSON.stringify to make sure it's equality check works
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be in a constant?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These don't all add up to 100%. Are they meant to wrap?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't believe you need this conditional. It appears as though the parent this is wrapped in already contains this conditional.