Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes a skipped management x-pack test #96178

Merged
merged 4 commits into from
Apr 5, 2021
Merged

fixes a skipped management x-pack test #96178

merged 4 commits into from
Apr 5, 2021

Conversation

rashmivkulkarni
Copy link
Contributor

@rashmivkulkarni rashmivkulkarni commented Apr 2, 2021 •
edited
Loading

Fixes #61173

  • added a bunch of data-test-subj to the page as user_form.tsx page
  • modified the test to fit to the new redesigned page.
  • added after()

@rashmivkulkarni rashmivkulkarni added test_ui_functional test_xpack_functional failed-test A test failure on a tracked branch, potentially flaky-test v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.13.0 labels Apr 2, 2021
@rashmivkulkarni rashmivkulkarni self-assigned this Apr 2, 2021
@rashmivkulkarni rashmivkulkarni requested a review from a team as a code owner April 2, 2021 21:27
@LeeDr
Copy link

LeeDr commented Apr 5, 2021

@elasticmachine merge upstream

jportner
jportner reviewed Apr 5, 2021
View reviewed changes
Copy link
Contributor

@jportner jportner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nits below!

x-pack/test/functional/apps/security/management.js Outdated Show resolved Hide resolved
x-pack/test/functional/apps/security/management.js Outdated Show resolved Hide resolved
LeeDr
LeeDr approved these changes Apr 5, 2021
View reviewed changes
Copy link

@LeeDr LeeDr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Once Jenkins CI passes

jportner
jportner approved these changes Apr 5, 2021
View reviewed changes
Copy link
Contributor

@jportner jportner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

x-pack/test/functional/apps/security/management.js Show resolved Hide resolved
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
security 681.4KB 681.6KB +198.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @rashmivkulkarni

@rashmivkulkarni rashmivkulkarni merged commit 7da1b82 into elastic:master Apr 5, 2021
@rashmivkulkarni rashmivkulkarni mentioned this pull request Apr 5, 2021
Merged
rashmivkulkarni added a commit to rashmivkulkarni/kibana that referenced this pull request Apr 5, 2021
@rashmivkulkarni @kibanamachine
fixes a skipped management x-pack test (elastic#96178)
b38aee8 
* fixes a skipped management x-pack test

* modified the test to incoroporate the review comments

Co-authored-by: Kibana Machine <[email protected]>
@rashmivkulkarni rashmivkulkarni mentioned this pull request Apr 5, 2021
Merged
rashmivkulkarni added a commit to rashmivkulkarni/kibana that referenced this pull request Apr 5, 2021
@rashmivkulkarni @kibanamachine
fixes a skipped management x-pack test (elastic#96178)
81dfe71 
* fixes a skipped management x-pack test

* modified the test to incoroporate the review comments

Co-authored-by: Kibana Machine <[email protected]>
rashmivkulkarni added a commit that referenced this pull request Apr 6, 2021
@rashmivkulkarni @kibanamachine
fixes a skipped management x-pack test (#96178) (#96267)
47af727 
* fixes a skipped management x-pack test

* modified the test to incoroporate the review comments

Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Kibana Machine <[email protected]>
rashmivkulkarni added a commit that referenced this pull request Apr 6, 2021
@rashmivkulkarni @kibanamachine
fixes a skipped management x-pack test (#96178) (#96266)
d81e635 
* fixes a skipped management x-pack test

* modified the test to incoroporate the review comments

Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Kibana Machine <[email protected]>
jloleysens added a commit to jloleysens/kibana that referenced this pull request Apr 6, 2021
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into sr/fix-wizard…
97ee8a6 
…-nav

* 'master' of github.com:elastic/kibana: (106 commits)
  [Lens] don't use eui variables for zindex (elastic#96117)
  Remove /src/legacy (elastic#95510)
  skip flaky suite (elastic#95899)
  [Dashboard] Fix Lens and TSVB chart tooltip positioning relative to global headers (elastic#94247)
  fixes a skipped management x-pack test (elastic#96178)
  [App Search] API logs: Add log detail flyout (elastic#96162)
  [tech-debt] Remove defunct opacity parameters from EUI shadow functions (elastic#96191)
  Add Input Controls project configuration (elastic#96238)
  [file upload] document file upload privileges and provide actionable UI when failures occur (elastic#95883)
  Revert "TS Incremental build exclude test files (elastic#95610)" (elastic#96223)
  [App Search] Added Sample Response section to Result Settings (elastic#95971)
  [Maps] Safe-erase text-field (elastic#94873)
  [RAC][Alert Triage][TGrid] Update the Alerts Table (TGrid) API to implement `renderCellValue` (elastic#96098)
  [Maps] Enable all zoom levels for all users (elastic#96093)
  Use plugin version in its publicPath (elastic#95945)
  [Enterprise Search] Expose core.chrome.setIsVisible for use in Workplace Search (elastic#95984)
  [Workplace Search] Add sub nav and fix rendering bugs in Personal dashboard (elastic#96100)
  [OBS]home page is showing incorrect value of APM throughput (tpm) (elastic#95991)
  [Observability] Exploratory View initial skeleton (elastic#94426)
  [KQL] Fixed styles of KQL textarea for the K8 theme (elastic#96190)
  ...

# Conflicts:
#	x-pack/plugins/snapshot_restore/__jest__/client_integration/helpers/restore_snapshot.helpers.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeeDr LeeDr LeeDr approved these changes

@jportner jportner jportner approved these changes

Assignees

@rashmivkulkarni rashmivkulkarni

Labels
failed-test A test failure on a tracked branch, potentially flaky-test release_note:skip Skip the PR/issue when compiling release notes test_ui_functional test_xpack_functional v7.13.0 v8.0.0
Projects
None yet
Milestone
No milestone
4 participants
@rashmivkulkarni @LeeDr @kibanamachine @jportner