Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Application Usage] Remove deprecated & unused legacy.appChanged API #91464

Merged

Conversation

afharo
Copy link
Member

@afharo afharo commented Feb 16, 2021

Summary

This API removes the deprecated API __LEGACY.appChanged. It was used to catch any app changes in the Legacy router. It looks like it's no longer used.

Also, as I was cleaning up the imports, I thought we might benefit from import type in 2 of the imports.

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@afharo afharo added Feature:Telemetry release_note:skip Skip the PR/issue when compiling release notes v7.13.0 labels Feb 16, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
usageCollection 20.7KB 20.5KB -211.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@afharo afharo marked this pull request as ready for review February 16, 2021 12:58
@afharo afharo requested a review from a team as a code owner February 16, 2021 12:58
Copy link
Contributor

@TinaHeiligers TinaHeiligers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TinaHeiligers
Copy link
Contributor

@afharo Would it make sense to open a meta issue for general Telemetry-related cleanup tasks we feel are needed before 8.0? To me, it would be a nice way to track all the things that we should be doing before then.

@afharo
Copy link
Member Author

afharo commented Feb 17, 2021

@afharo Would it make sense to open a meta issue for general Telemetry-related cleanup tasks we feel are needed before 8.0? To me, it would be a nice way to track all the things that we should be doing before then.

Good idea! I've created #91611 to track them all and their related effort. Feel free to add more items.

@afharo afharo merged commit bc207ff into elastic:master Feb 17, 2021
@afharo afharo deleted the application_usage/remove-legacy-appChanged-api branch February 17, 2021 10:01
@afharo afharo added v7.12.0 and removed v7.13.0 labels Feb 17, 2021
gmmorris added a commit to gmmorris/kibana that referenced this pull request Feb 17, 2021
* master: (157 commits)
  [DOCS] Adds machine learning to the security section of alerting (elastic#91501)
  [Uptime] Ping list step screenshot caption formatting (elastic#91403)
  [Vislib] Use timestamp on brush event instead of iso dates (elastic#91483)
  [Application Usage] Remove deprecated & unused legacy.appChanged API (elastic#91464)
  Migrate logstash, monitoring, url_drilldowns, xpack_legacy to ts projects (elastic#91194)
  [APM] Wrap Elasticsearch client errors (elastic#91125)
  [APM] Fix optimize-tsconfig script (elastic#91487)
  [Discover][docs] Add searchFieldsFromSource description (elastic#90980)
  Adds support for 'ip' data type (elastic#85087)
  [Detection Rules] Add updates from 7.11.2 rules (elastic#91553)
  [SECURITY SOLUTION] Eql in timeline (elastic#90816)
  [APM] Correlations Beta (elastic#86477) (elastic#89952)
  [Security Solutions][Detection Engine] Adds a warning banner when the alerts data has not been migrated yet. (elastic#90258)
  [Security Solution] [Timeline] Endpoint row renderers (2nd batch) (elastic#91446)
  skip flaky suite (elastic#91450)
  skip flaky suite (elastic#91592)
  [Security Solution][Endpoint][Admin] Endpoint Details UX Enhancements (elastic#90870)
  [ML] Add better UI support for runtime fields Transforms  (elastic#90363)
  [Security Solution] [Detections] Replace 'partial failure' with 'warning' for rule statuses (elastic#91167)
  [Security Solution][Detections] Adds Indicator path config for indicator match rules (elastic#91260)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Telemetry release_note:skip Skip the PR/issue when compiling release notes v7.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants