-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SECURITY SOLUTION] Eql in timeline #90816
Conversation
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
src/plugins/data/public/ui/query_string_input/language_switcher.test.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/security_solution/server/search_strategy/timeline/factory/events/all/helpers.ts
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
x-pack/plugins/security_solution/public/detections/components/rules/eql_query_bar/footer.tsx
Show resolved
Hide resolved
src/plugins/data/public/ui/query_string_input/language_switcher.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/security_solution/public/detections/components/rules/eql_query_bar/footer.tsx
Outdated
Show resolved
Hide resolved
..._solution/public/timelines/components/timeline/body/column_headers/header/header_content.tsx
Show resolved
Hide resolved
@@ -6,6 +6,7 @@ | |||
*/ | |||
|
|||
import React from 'react'; | |||
import { isEmpty } from 'lodash'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
consider changing this to
import { isEmpty } from 'lodash/fp';
for consistency with other imports of isEmpty
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kibana wants us to use lodash directly
* 2.0. | ||
*/ | ||
|
||
import { isEmpty, isEqual } from 'lodash'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
consider changing this to
import { isEmpty, isEqual } from 'lodash/fp';
I can tab through all the elements on the page when in the |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
...lugins/security_solution/public/timelines/components/timeline/eql_tab_content/index.test.tsx
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Per the following screenshot, when a case is created from a Resolver view, additional URL state is included to re-open the Resolver view when users click the rule from a case: Consider appending the active tab to the URL state such that when users click on a timeline link from a case, timeline opens the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this milestone PR @XavierM! 🎉
LGTM 🚀
💚 Build SucceededMetrics [docs]Module Count
Async chunks
Page load bundle
Saved Objects .kibana field count
History
To update your PR or re-run it, just comment with: |
* master: (157 commits) [DOCS] Adds machine learning to the security section of alerting (elastic#91501) [Uptime] Ping list step screenshot caption formatting (elastic#91403) [Vislib] Use timestamp on brush event instead of iso dates (elastic#91483) [Application Usage] Remove deprecated & unused legacy.appChanged API (elastic#91464) Migrate logstash, monitoring, url_drilldowns, xpack_legacy to ts projects (elastic#91194) [APM] Wrap Elasticsearch client errors (elastic#91125) [APM] Fix optimize-tsconfig script (elastic#91487) [Discover][docs] Add searchFieldsFromSource description (elastic#90980) Adds support for 'ip' data type (elastic#85087) [Detection Rules] Add updates from 7.11.2 rules (elastic#91553) [SECURITY SOLUTION] Eql in timeline (elastic#90816) [APM] Correlations Beta (elastic#86477) (elastic#89952) [Security Solutions][Detection Engine] Adds a warning banner when the alerts data has not been migrated yet. (elastic#90258) [Security Solution] [Timeline] Endpoint row renderers (2nd batch) (elastic#91446) skip flaky suite (elastic#91450) skip flaky suite (elastic#91592) [Security Solution][Endpoint][Admin] Endpoint Details UX Enhancements (elastic#90870) [ML] Add better UI support for runtime fields Transforms (elastic#90363) [Security Solution] [Detections] Replace 'partial failure' with 'warning' for rule statuses (elastic#91167) [Security Solution][Detections] Adds Indicator path config for indicator match rules (elastic#91260) ...
* add EQL as a language * add eql in timeline * fix type + unit test * move eql to it sown tab * fix merge issue + a liitle bug when creating anew timeline to reset eql textarea * fix cypress tests * fix lint error * fix bug from review Co-authored-by: Angela Chuang <[email protected]>
* add EQL as a language * add eql in timeline * fix type + unit test * move eql to it sown tab * fix merge issue + a liitle bug when creating anew timeline to reset eql textarea * fix cypress tests * fix lint error * fix bug from review Co-authored-by: Angela Chuang <[email protected]> Co-authored-by: Angela Chuang <[email protected]>
Summary
Timeline can support EQL query.
Checklist