[Uptime] Improve filter group #88185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinkambic
added
bug
justinkambic
force-pushed
the
uptime_improve-filter-group
branch
from
a76cac1 to
452882c
Compare
justinkambic
force-pushed
the
uptime_improve-filter-group
branch
from
452882c to
0d27256
Compare
justinkambic
added
release_note:skip
|
Pinging @elastic/uptime (Team:uptime) |
shahzad31
reviewed
Jan 19, 2021
| schemes: [], | ||
| locations: ['nyc', 'fairbanks'], | ||
| }, | ||
| filterAriaLabels.TAG, |
There was a problem hiding this comment.
will it be filterAriaLabels.TAG in all cases?
There was a problem hiding this comment.
Sorry, I misunderstood your ask. I will address this.
shahzad31
reviewed
Jan 19, 2021
| if (isOpen) { | ||
| // only update these values on close | ||
| onFilterFieldChange(fieldName, tempSelectedItems); | ||
| } |
There was a problem hiding this comment.
Thanks to RTL 🚀
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
shahzad31
approved these changes
Jan 20, 2021
|
@shahzad31 please have a look at 8fb99f5 and re-approve if it looks good to you. Thanks! |
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
This was referenced Jan 21, 2021
justinkambic
added a commit
to justinkambic/kibana
that referenced
this pull request
Jan 21, 2021
* Unskip "Observer location" test block. * Commit temp "describe.only" to make flaky test runner go faster. * Add optional chain for some potentially-null props. * Make overview filters type partial. * Repair broken types. * Remove only call from test. * Add unit tests and mark areas for improvement in \`FilterGroup\` component. * Add aria-label translations and new labels. * Refactor existing tests and add tests for new labels. * Fix bug in event handler and update tests. * Delete a comment. * Delete a comment. * Add some line breaks to help readability. * Add additional tests, fix a bug. Co-authored-by: Kibana Machine <[email protected]>
justinkambic
added a commit
that referenced
this pull request
Jan 21, 2021
* Unskip "Observer location" test block. * Commit temp "describe.only" to make flaky test runner go faster. * Add optional chain for some potentially-null props. * Make overview filters type partial. * Repair broken types. * Remove only call from test. * Add unit tests and mark areas for improvement in \`FilterGroup\` component. * Add aria-label translations and new labels. * Refactor existing tests and add tests for new labels. * Fix bug in event handler and update tests. * Delete a comment. * Delete a comment. * Add some line breaks to help readability. * Add additional tests, fix a bug. Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
justinkambic
added a commit
that referenced
this pull request
Jan 21, 2021
* Unskip "Observer location" test block. * Commit temp "describe.only" to make flaky test runner go faster. * Add optional chain for some potentially-null props. * Make overview filters type partial. * Repair broken types. * Remove only call from test. * Add unit tests and mark areas for improvement in \`FilterGroup\` component. * Add aria-label translations and new labels. * Refactor existing tests and add tests for new labels. * Fix bug in event handler and update tests. * Delete a comment. * Delete a comment. * Add some line breaks to help readability. * Add additional tests, fix a bug. Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
|
Backported to: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
note to reviewers, do not review until #87571 is mergedResolves #88180.
Adds unit tests for the
FilterGroupComponentto ensure appropriate text is displayed during loading and when items are present, and ensures the popover functionality displays filter items.An additional focus of this PR is improving a11y concerns while this code is being touched for test add. Improving the state of
aria-labels not only improves the UX for users that rely on these attributes, it makes testing easier as well.Checklist
Delete any items that are not applicable to this PR.
For maintainers