Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Uptime] FilterGroup component is untested and has accessibility issues #88180

Closed
justinkambic opened this issue Jan 13, 2021 · 1 comment · Fixed by #88185
Closed

[Uptime] FilterGroup component is untested and has accessibility issues #88180

justinkambic opened this issue Jan 13, 2021 · 1 comment · Fixed by #88185
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability test-plan test-plan-ok issue has passed test plan v7.12.0

Comments

@justinkambic
Copy link
Contributor

Kibana version:
edge

Elasticsearch version:
edge

Server OS version:
macOS

Browser version:
Chrome 87

Browser OS version:
macOS

Original install method (e.g. download page, yum, from source, etc.):
from source

Describe the bug:
The FilterGroup component in the Uptime app is untested, and several key elements are missing aria-labels which, if added, could significantly improve the UX for users relying on these fields.

Steps to reproduce:

  1. Attempt to run the test suite for FilterGroup
  2. There isn't one

Expected behavior:
There should be unit tests and appropriate accessibility labeling.

Screenshots (if relevant):
N/A

Errors in browser console (if relevant):
N/A

Provide logs and/or server output (if relevant):
N/A

Any additional context:

@justinkambic justinkambic added bug Fixes for quality problems that affect the customer experience Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability labels Jan 13, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability test-plan test-plan-ok issue has passed test plan v7.12.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants