Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [Uptime] Improve filter group (#88185) #88964

Merged
merged 1 commit into from
Jan 21, 2021

Conversation

justinkambic
Copy link
Contributor

Backports the following commits to 7.x:

* Unskip "Observer location" test block.

* Commit temp "describe.only" to make flaky test runner go faster.

* Add optional chain for some potentially-null props.

* Make overview filters type partial.

* Repair broken types.

* Remove only call from test.

* Add unit tests and mark areas for improvement in \`FilterGroup\` component.

* Add aria-label translations and new labels.

* Refactor existing tests and add tests for new labels.

* Fix bug in event handler and update tests.

* Delete a comment.

* Delete a comment.

* Add some line breaks to help readability.

* Add additional tests, fix a bug.

Co-authored-by: Kibana Machine <[email protected]>
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
uptime 1.1MB 1.1MB +1.5KB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@justinkambic justinkambic self-assigned this Jan 21, 2021
@justinkambic justinkambic added Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.12.0 labels Jan 21, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@justinkambic justinkambic merged commit b886d65 into elastic:7.x Jan 21, 2021
@justinkambic justinkambic deleted the backport/7.x/pr-88185 branch January 21, 2021 20:46
@justinkambic justinkambic mentioned this pull request Jan 21, 2021
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants