Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core UI] Home Page Solution Cards Fix #75670

Merged
merged 3 commits into from
Aug 24, 2020

Conversation

MichaelMarcialis
Copy link
Contributor

Summary

Hey, @cqliu1! Here's my fix for the solution cards' flexbox issue since applying the wrapping a elements (thanks again for changing that). Whenever you have a moment, take a peek and let me know if you have any questions/suggestions. Changes include:

  • Updated solution cards' flexbox styles to account for new wrapping a element.
  • Updated solution cards' hover and focus styles to account for new wrapping a element.
  • Changed a handful of icons in order to better match their updated wording.

Parent Issue: #70571

@MichaelMarcialis MichaelMarcialis added the REASSIGN from Team:Core UI Deprecated label for old Core UI team label Aug 21, 2020
@MichaelMarcialis MichaelMarcialis requested review from ryankeairns, cqliu1 and a team August 21, 2020 16:10
@MichaelMarcialis MichaelMarcialis requested review from a team as code owners August 21, 2020 16:10
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core-ui (Team:Core UI)

@botelastic botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Aug 21, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest-management (Team:Ingest Management)

@jen-huang jen-huang requested a review from hbharding August 21, 2020 16:38
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

async chunks size

id value diff baseline
home 568.2KB +4.0KB 564.3KB

page load bundle size

id value diff baseline
ingestManager 466.7KB +5.0B 466.7KB
ml 577.1KB -4.0B 577.1KB
total +1.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@ryankeairns
Copy link
Contributor

Chatted with Henry on Slack, he stated that he liked what we chose. He is on PTO, so we can move ahead and consider this his approval.

@cqliu1 cqliu1 merged commit b8e49e7 into elastic:elastic-home-page Aug 24, 2020
@MichaelMarcialis MichaelMarcialis deleted the fix-solution-cards branch August 24, 2020 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
REASSIGN from Team:Core UI Deprecated label for old Core UI team Team:Fleet Team label for Observability Data Collection Fleet team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants