Skip to content

Commit

Permalink
[Core UI] Home Page Solution Cards Fix (#75670)
Browse files Browse the repository at this point in the history
  • Loading branch information
MichaelMarcialis authored Aug 24, 2020
1 parent 80109c8 commit b8e49e7
Show file tree
Hide file tree
Showing 11 changed files with 69 additions and 34 deletions.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

22 changes: 22 additions & 0 deletions src/plugins/home/public/application/components/_add_data.scss
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
/*
* Licensed to Elasticsearch B.V. under one or more contributor
* license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright
* ownership. Elasticsearch B.V. licenses this file to you under
* the Apache License, Version 2.0 (the "License"); you may
* not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/

.homDataAdd__content .euiIcon__fillSecondary {
fill: $euiColorDarkestShade;
}
1 change: 1 addition & 0 deletions src/plugins/home/public/application/components/_index.scss
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
// homChart__legend-isLoading

@import 'home';
@import 'add_data';
@import 'manage_data';
@import 'sample_data_set_cards';
@import 'solutions_section';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,21 +38,29 @@
}

.homSolutionPanel {
align-items: stretch; // Necessary because element is a button
display: flex !important;
flex-direction: column;
overflow: hidden;
border-radius: $euiBorderRadius;
color: inherit;
flex: 1;
transition: all $euiAnimSpeedFast $euiAnimSlightResistance;

&:hover,
&:focus {
@include euiSlightShadowHover;
transform: translateY(-2px);

&:focus,
&:hover {
.euiTitle {
text-decoration: underline;
}
}

&:focus {
@include euiFocusRing('large');
@include euiSlightShadowHover;
&,
.euiPanel {
display: flex;
flex-direction: column;
}

.euiPanel {
overflow: hidden;
}
}

Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ const mockFeatures = [
category: 'admin',
description: 'Add and manage your fleet of Elastic Agents and integrations.',
homePageSection: 'add_data',
icon: 'logstashInput',
icon: 'indexManagementApp',
id: 'ingestManager',
order: 510,
path: '/app/ingestManager',
Expand All @@ -77,7 +77,7 @@ const mockFeatures = [
category: 'data',
description: 'Import your own CSV, NDJSON, or log file',
homePageSection: 'add_data',
icon: 'importAction',
icon: 'document',
id: 'ml_file_data_visualizer',
order: 520,
path: '/app/ml#/filedatavisualizer',
Expand Down
2 changes: 1 addition & 1 deletion src/plugins/home/public/application/components/home.js
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ export class Home extends Component {
<EuiFlexItem grow={false}>
<EuiFlexGroup className="homHeader__actions">
<EuiFlexItem className="homHeader__actionItem">
<EuiButtonEmpty href="#/tutorial_directory" iconType="plusInCircle">
<EuiButtonEmpty href="#/tutorial_directory" iconType="indexOpen">
{i18n.translate('home.pageHeader.addDataButtonLabel', {
defaultMessage: 'Add data',
})}
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -58,8 +58,12 @@ export const SolutionPanel: FC<Props> = ({ addBasePath, solution }) => (
} homSolutions__item`}
grow={1}
>
<a href={addBasePath(solution.path)} onClick={createAppNavigationHandler(solution.path)}>
<EuiPanel paddingSize="none" className={`homSolutionPanel homSolutionPanel--${solution.id}`}>
<a
className={`homSolutionPanel homSolutionPanel--${solution.id}`}
href={addBasePath(solution.path)}
onClick={createAppNavigationHandler(solution.path)}
>
<EuiPanel paddingSize="none">
<EuiFlexGroup gutterSize="none">
<EuiFlexItem grow={1} className={`homSolutionPanel__header`}>
<SolutionTitle
Expand Down
2 changes: 1 addition & 1 deletion x-pack/plugins/ingest_manager/public/plugin.ts
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ export class IngestManagerPlugin
description: i18n.translate('xpack.ingestManager.featureCatalogueDescription', {
defaultMessage: 'Add and manage your fleet of Elastic Agents and integrations.',
}),
icon: 'logstashInput',
icon: 'indexManagementApp',
showOnHomePage: true,
path: BASE_PATH,
category: FeatureCatalogueCategory.DATA,
Expand Down
2 changes: 1 addition & 1 deletion x-pack/plugins/ml/public/register_feature.ts
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ export const registerFeature = (home: HomePublicPluginSetup) => {
description: i18n.translate('xpack.ml.fileDataVisualizerDescription', {
defaultMessage: 'Import your own CSV, NDJSON, or log file.',
}),
icon: 'importAction',
icon: 'document',
path: '/app/ml#/filedatavisualizer',
showOnHomePage: true,
category: FeatureCatalogueCategory.DATA,
Expand Down

0 comments on commit b8e49e7

Please sign in to comment.