-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Home] Elastic home page redesign #70571
Conversation
@cqliu1 I keep getting optimizations errors when attempting to try out the PR, but I recall seeing a screenshot or demo in which the Kibana box didn't fully fill out as shown in the mockup above. Is it possible to match @MichaelMarcialis designs or is there a limitation within EUI to make the component "that" flexible? |
50b76f4
to
2753c39
Compare
I've just updated the branch with the latest changes if you want to try pulling it down. Let me know if you're still getting errors.
The image above is actually an updated screenshot from the current state of this feature branch after working some CSS magic. The blue background on the Kibana card now stretches to the full size of the card when all solutions are visible as shown above. |
I don't know what's going on, but I still am running into errors running this PR locally 🤦 The screenshot looks amazing! I can't believe that's the real deal 😄 I have a few quick comments, and we can discuss more during our sync later today.
|
b78d697
to
6a1c38d
Compare
@ryankeairns @cqliu1 I was able to get the PR,
|
@alexfrancoeur which security icon are you referring to? Somewhat unfortunately, we are using this term for two different things on the home page. Gail did provide some copy for the 'set default route' link: Catherine pointed out that Spaces don't exist on OSS (right?)... so suggested: If we were to remove the directory link, there won't be a way to access that page any longer. Is that a desired outcome of removing the link? The links in the header are the literal page/feature names. That being the case, should Manage Stack then be Stack Management? I don't have a strong feeling on this vs Manage but point it out for consistency. |
Initially, I was using the |
6a1c38d
to
cdf95e3
Compare
I know we discussed yesterday, but reiterating here for anyone who is watching this PR. We'll need to update the App Search to be Enterprise Search and @ryankeairns will be reaching out to the Enterprise Search team to either provide us the link to their Overview page or the default app they'd like to navigate to. |
Update: I chatted briefly with @johnbarrierwilson and it sounds like they're planning to have a basic Overview page - referred to as the Enterprise Search home - in the 7.10 timeframe. If that slips, then we can confirm which page we should point to in the meantime. |
cdf95e3
to
1304b2c
Compare
@ryankeairns @cqliu1 I had some time to play around with the updated PR this morning. Regarding enterprise search, for the mean time, should we just link out to app search so we're not blocked? Right now the link to enterprise search points to When clicking into the Observability link, it seems to redirect from I've added a comment here, but I think the empty index pattern state will play an important role in getting started while we're missing the Kibana landing and overview pages. Some additional feedback: I created a role that has read only access to the e-commerce index and write access to Kibana apps. This means that with this role, I can't ingest data or manage indices in any form or fashion.
Also, I'm not sure if this is helpful but I thought I'd summarize some of my comments earlier and from our discussion this week in marked up screenshot. I think we'll need some additional input from @gchaps on a bit of this text. |
@alexfrancoeur Here are some suggestions and comments. Once we decide on the text, I'll add it to the google doc, so we have all the text changes in one place. TitleOur discussion on Slack landed with either no title or "Give your data shape" ManageGood point on users not knowing what the stack is. Manage alone works, but would be better if followed by a noun. Do you have a suggestion? Add your data (middle card)Load data OR Ingest data Add your data (right card)Add Elastic Agents FooterOne line: Make this the home page for this space. OR Change the home page for this space. |
Ew, I'm hopeful we can do something more friendly. I'll run this locally to get a better feel... I'm not sure what sort of permission checks we can do to prevent/hide this, but there must be something. |
Thanks for the quick response @gchaps! For the title, "Give your data shape" feels less tactical and a bit more marketing, where the other titles are quite task oriented ("Add your data", "Manage your data") I liked the route you were going with "Gain insights on your data", is there a reason we dropped them? Manage is a tough one. The only other alternative I can think of is "Management". I feel like either of these options are common enough that they're straight forward, similar to "Settings" or "Configuration". I'd like to say "Manage data", but we say data a lot here and also reference this at the bottom of the page. Maybe that's OK and having 1:1 mapping is a good thing? For the add data middle card, this option looks best to me.
The other alternative I can think of is to flip the title of that section with ingest like this.
+1 on the fleet changes for the second add data card Quick question on the footer Gail. We've learned that the setting for this feature only changes the default landing page for when you log in and not actually changing the "home page". The more I think about it, the more I lean towards potentially not differentiating for simplification. Knowing this, does that change your suggestion at all? |
@alexfrancoeur After reading through your comments, here is what I think we should go with: Title: "Gain insights to your data" or "Gain insight to data". (It fits better with the page, as you pointed out) Link in upper right: Manage Section title: Add your data (it's easier to read) Card: Ingest data (although ingest is one of our common terms, it might be better to come up with something more friendly for a new user) Footer suggestions: Like this page? Make it the default landing page for this space. |
Thanks @gchaps! Should we use the google doc as the source of truth for @cqliu1 ? One last bit about the landing page, rather than having the action item to make it your landing page we've decided to make the action item to change your landing page. The reasoning behind this is that this is the default experience. Most likely, this will be the clusters landing page. Any way we can make the two options below read better? Basic+
OSS
|
Initial design PR: #72481 |
@alexfrancoeur I've been keeping the google doc up-to-date. Good idea to make that doc the source of truth. Both of your suggestions sound good to me. We could probably omit the word "default" though.
|
After a few conversations, we've decided that we cannot get rid of the feature directory as it exists today until we also support in search (I just opened #72680). That being said, given the limited functionality available, it doesn't make sense to make it a primary CTA. Can we adjust the design so that there is a subtle link at the bottom somehow? @ryankeairns @MichaelMarcialis |
We could move it to the bottom, but part of me thinks it still makes the most sense as the last (i.e. least important) link in the top-right list of links (add data, manage stack, dev tools, app directory). That said though, I'll defer to your instincts if it's something you feel very strongly about. |
Thanks Michael, in its current state, I'd prefer to hide the feature directory as much as possible. Moving it to a top item gives it significantly more visibility. It's quite incomplete and is now a mix between tasks and features. |
fae3ec1
to
50dfd3e
Compare
I chatted with @legrego about this, and the issue is there isn't currently a way to check a user's access to ES features, i.e. security, ingest manager, and index lifecycle management (see #35965), so these cards will appear on the home page for users even if they don't have access to these parts of stack management and lead them to that permission denied errors. |
@MichaelMarcialis I can handle wrapping the panel in an |
@cjcenizal The Enterprise Search link now points to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for stack monitoring!
A few comments here:
@hmnichols , @jae-elastic , @MarkSettleES , @MikePaquette , @ryankeairns |
Thanks @bradenlpreston , so that I'm clear, you're suggesting the main title on the 3 left-hand cards be Search, Observe, and Protect with the subtitle on the Protect card reading SIEM & Endpoint Security? |
@ryankeairns - For the subheading on what is currently security. We can change that to |
@bradenlpreston ok, let's do this. We'll change the Security subtitle in this PR, as proposed, then let's get together with @alexfrancoeur , et al, next week when he returns from PTO. He's been leading the PM side of this particular project and I'm sure he would like to hear your feedback and discuss further. That aside, we will likely merge this PR this week to keep the project moving (there are some related landing pages in the works as well) and there will be plenty of time to make desired copy changes prior to the 7.10 feature freeze. Thanks for the feedback, aligning with the recently launched website seem like a smart move! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
KibanaApp owned code LGTM, code owner review, checked out locally in Chrome, KibanaApp owned plugins are no longer displayed as single plugins, but this is no reason to feel blue, since "Kibana Visualize & analyze" is actually blue🎨. Nice redesign. One thought, the blue banner could e.g. show the plugins links on hover, or e.g. "Plot geographic data" could link to Maps.
@kertal thanks for the review and feedback. There is an accompanying Kibana/analyze landing page (under development) that the blue card will link to. That page will display and link to all the underlying products! |
@ryankeairns thx, really like this upcoming landing page ❤️ |
💚 Build SucceededBuild metrics@kbn/optimizer bundle module count
async chunks size
page load bundle size
oss distributable file count
distributable file count
History
To update your PR or re-run it, just comment with: |
Co-authored-by: Catherine Liu <[email protected]> Co-authored-by: Ryan Keairns <[email protected]> Co-authored-by: Catherine Liu <[email protected]> Co-authored-by: Michael Marcialis <[email protected]>
Co-authored-by: Catherine Liu <[email protected]> Co-authored-by: Ryan Keairns <[email protected]> Co-authored-by: Catherine Liu <[email protected]> Co-authored-by: Michael Marcialis <[email protected]> Co-authored-by: Ryan Keairns <[email protected]> Co-authored-by: Michael Marcialis <[email protected]>
Summary
Closes #25734.
This redesigns the Elastic home page as described in the issue above with the goal of decluttering the home page while highlighting a few of our solutions.
Screenshots
With access to all features
Note: The Observability and Security links direct the user to each solutions respective overview page. The Enterprise Search link directs the user to App Search until their overview page is shipped. The Kibana link directs the user to Dashboard for now until the Kibana landing page is complete (see #61549).
(Updated 8/24/2020)
OSS
(Updated 8/24/2020)
Checklist
Delete any items that are not applicable to this PR.
For maintainers