Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [Uptime] Reduce miscellaneous uptime bundle size (#70632) #73733

Merged
merged 3 commits into from
Jul 30, 2020

Conversation

shahzad31
Copy link
Contributor

Backports the following commits to 7.x:

@shahzad31
Copy link
Contributor Author

@elasticmachine merge upstream

elasticmachine and others added 2 commits July 30, 2020 06:58
* Add await to promise.

* Remove lazy loading and reference to lazy resource from validation.

* Revert previous changes and add simpler fix.

* Remove unnecessary formatting changes.

* Further cleanup.

* Add more descriptive import path.

* fix type

* fix type

Co-authored-by: Shahzad <[email protected]>
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

@kbn/optimizer bundle module count

id value diff baseline
uptime 502 +2 500

async chunks size

id value diff baseline
uptime 1.6MB +976.8KB 620.3KB

page load bundle size

id value diff baseline
triggers_actions_ui 263.2KB +93.0B 263.2KB
uptime 23.7KB -463.1KB 486.7KB
total - -463.0KB -

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@shahzad31 shahzad31 merged commit 4f92b68 into elastic:7.x Jul 30, 2020
@shahzad31 shahzad31 deleted the backport/7.x/pr-70632 branch July 30, 2020 17:18
@justinkambic justinkambic mentioned this pull request Jul 31, 2020
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants