[Uptime] Repair Alert Flyout

[justinkambic]

Summary

Fixes #73527.

This PR fixes the alert flyout in the Uptime solution UI.

An animation of the current state of the flyout is available in the linked issue. The result of this change is depicted below:

Testing this PR

1. Open the Uptime Solution
2. Open the Monitor Status alert flyout
3. Ensure the flyout loads

Checklist

Delete any items that are not applicable to this PR.

• Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
• Documentation was added for features that require explanation or tutorials
• Unit or functional tests were updated or added to match the most common scenarios
• This was checked for keyboard-only and screenreader accessibility
• This renders correctly on smaller devices using a responsive layout. (You can test this in your browser
• This was checked for cross-browser compatibility

For maintainers

• This was checked for breaking API changes and was labeled appropriately

[elasticmachine]

Pinging @elastic/uptime (Team:uptime)

[justinkambic]

@shahzad31 I realized my previous patch won't work because it doesn't satisfy the typing constraint. The validation function isn't allowed to return a Promise. Let me know if the change in f5e2705 works for you. I've removed the validation function's dependency on triggers_actions_ui, so it isn't depending on any external plugin code, and the inferred type it returns works for the API typing.

[shahzad31]

@shahzad31 I realized my previous patch won't work because it doesn't satisfy the typing constraint. The validation function isn't allowed to return a Promise. Let me know if the change in f5e2705 works for you. I've removed the validation function's dependency on triggers_actions_ui, so it isn't depending on any external plugin code, and the inferred type it returns works for the API typing.

@justinkambic why not update types to handle this use case? change is fine, it's just it will increase uptime page load bundle size by adding fp-ts etc into it. Earlier it was lazy loaded only when validate was called.

[justinkambic]

@mikecote do you think it would be an acceptable change to convert the AlertType's validate function type to ValidationResult | Promise<ValidationResult>? It would obviously require some revision within triggers_actions_ui as well.

EDIT: disregard, Shahzad came up with a better solution that requires no changes.

[shahzad31]

you will also need to revert this, actually when you import it from index.ts file, it ends up bundling everything from that index file into the imported bundle.

[justinkambic]

Thanks for pointing that out. I had consider reverting it and didn't think it would impact. I was wrong! Fixed this in b1b8b78.

[kibanamachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: 38b7925

Build metrics

page load bundle size

id	value	diff	baseline
uptime	23.7KB	+2.0B	23.7KB

History

• 💔 Build #65388 failed b1b8b78
• 💔 Build #65338 failed bec3f0c
• 💚 Build #64907 succeeded f5e2705
• 💔 Build #64833 failed 6bbea81edfa94f3002df2da9e79a86456520963f

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[shahzad31]

LGTM !!

[justinkambic]

This PR didn't get backported directly. Because this PR is a fix for a defect previously-injected, we cherry-picked this commit to an existing backport PR #73733.